third_party/protobuf/js/debug.js - Issue 2495533002: third_party/protobuf: Update to HEAD (83d681ee2c)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/protobuf/js/debug.js

Issue 2495533002: third_party/protobuf: Update to HEAD (83d681ee2c) (Closed)

Patch Set: Make chrome settings proto generated file a component Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/protobuf/js/debug.js

diff --git a/third_party/protobuf/js/debug.js b/third_party/protobuf/js/debug.js

index 3701a0957ea05863dee4f547545cc9da9b8b529c..46b24853150af52ee70024f18beeb0680398fcf0 100644

--- a/third_party/protobuf/js/debug.js

+++ b/third_party/protobuf/js/debug.js

@@ -94,8 +94,9 @@ jspb.debug.dump_ = function(thing) {

var match = /^get([A-Z]\w*)/.exec(name);

if (match && name != 'getExtension' &&

name != 'getJsPbMessageId') {

- var val = thing[name]();

- if (val != null) {

+ var has = 'has' + match[1];

+ if (!thing[has] || thing[has]()) {

+ var val = thing[name]();

object[jspb.debug.formatFieldName_(match[1])] = jspb.debug.dump_(val);

}