third_party/protobuf/src/google/protobuf/util/internal/json_objectwriter_test.cc - Issue 2495533002: third_party/protobuf: Update to HEAD (83d681ee2c)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/protobuf/src/google/protobuf/util/internal/json_objectwriter_test.cc

Issue 2495533002: third_party/protobuf: Update to HEAD (83d681ee2c) (Closed)

Patch Set: Make chrome settings proto generated file a component Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/protobuf/src/google/protobuf/util/internal/json_objectwriter.cc ('k') | third_party/protobuf/src/google/protobuf/util/internal/json_stream_parser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/protobuf/src/google/protobuf/util/internal/json_objectwriter_test.cc

diff --git a/third_party/protobuf/src/google/protobuf/util/internal/json_objectwriter_test.cc b/third_party/protobuf/src/google/protobuf/util/internal/json_objectwriter_test.cc

index b87b06ac788392b36acab01ded98200ad1ae27d5..bbd9d78a43aad5fb818ff6910a75af72a35c4c77 100644

--- a/third_party/protobuf/src/google/protobuf/util/internal/json_objectwriter_test.cc

+++ b/third_party/protobuf/src/google/protobuf/util/internal/json_objectwriter_test.cc

@@ -299,11 +299,11 @@ TEST_F(JsonObjectWriterTest, TestWebsafeByteEncoding) {

ow_ = new JsonObjectWriter("", out_stream_);

ow_->set_use_websafe_base64_for_bytes(true);

ow_->StartObject("")

- ->RenderBytes("bytes", "\x03\xef\xc0")

+ ->RenderBytes("bytes", "\x03\xef\xc0\x10")

->EndObject();

// Test that we get websafe base64 encoding when explicitly asked.

- EXPECT_EQ("{\"bytes\":\"A-_A\"}",

+ EXPECT_EQ("{\"bytes\":\"A-_AEA==\"}",

output_.substr(0, out_stream_->ByteCount()));

}