third_party/protobuf/src/google/protobuf/compiler/csharp/csharp_generator.cc - Issue 2495533002: third_party/protobuf: Update to HEAD (83d681ee2c)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/protobuf/src/google/protobuf/compiler/csharp/csharp_generator.cc

Issue 2495533002: third_party/protobuf: Update to HEAD (83d681ee2c) (Closed)

Patch Set: Make chrome settings proto generated file a component Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/protobuf/src/google/protobuf/compiler/csharp/csharp_generator.h ('k') | third_party/protobuf/src/google/protobuf/compiler/csharp/csharp_map_field.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/protobuf/src/google/protobuf/compiler/csharp/csharp_generator.cc

diff --git a/third_party/protobuf/src/google/protobuf/compiler/csharp/csharp_generator.cc b/third_party/protobuf/src/google/protobuf/compiler/csharp/csharp_generator.cc

index d74e8c8847208fa7fa35669f6cae9509c00cf3d3..c13ed65beced978bae01b6c4470afec2d0b139f7 100644

--- a/third_party/protobuf/src/google/protobuf/compiler/csharp/csharp_generator.cc

+++ b/third_party/protobuf/src/google/protobuf/compiler/csharp/csharp_generator.cc

@@ -83,9 +83,6 @@ bool Generator::Generate(

cli_options.base_namespace_specified = true;

} else if (options[i].first == "internal_access") {

cli_options.internal_access = true;

- } else if (options[i].first == "legacy_enum_values") {

- // TODO: Remove this before final release

- cli_options.legacy_enum_values = true;

} else {

*error = "Unknown generator option: " + options[i].first;

return false;