Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2495523002: Change 'LOG(ERROR)' to 'VLOG(1)' in mojo bits. (Closed)

Created:
4 years, 1 month ago by Mike West
Modified:
3 years, 5 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change 'LOG(ERROR)' to 'VLOG(1)' in mojo bits. These are likely important messages to capture, but they're not important enough to fill developers' logs when testing locally. BUG=656875, 664154

Patch Set 1 #

Total comments: 1

Patch Set 2 : badmessage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M services/catalog/entry.cc View 10 chunks +13 lines, -13 lines 0 comments Download
M services/service_manager/public/cpp/lib/interface_registry.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Mike West
Hey ben@, rockot@: WDYT of this small change?
4 years, 1 month ago (2016-11-10 14:37:29 UTC) #2
Ben Goodger (Google)
https://codereview.chromium.org/2495523002/diff/1/services/service_manager/public/cpp/lib/interface_registry.cc File services/service_manager/public/cpp/lib/interface_registry.cc (right): https://codereview.chromium.org/2495523002/diff/1/services/service_manager/public/cpp/lib/interface_registry.cc#newcode210 services/service_manager/public/cpp/lib/interface_registry.cc:210: VLOG(1) << ss.str(); We should leave this one as ...
4 years, 1 month ago (2016-11-10 14:44:08 UTC) #3
Mike West
On 2016/11/10 at 14:44:08, ben wrote: > https://codereview.chromium.org/2495523002/diff/1/services/service_manager/public/cpp/lib/interface_registry.cc > File services/service_manager/public/cpp/lib/interface_registry.cc (right): > > https://codereview.chromium.org/2495523002/diff/1/services/service_manager/public/cpp/lib/interface_registry.cc#newcode210 ...
4 years, 1 month ago (2016-11-10 15:07:43 UTC) #4
Ben Goodger (Google)
On 2016/11/10 15:07:43, Mike West wrote: > On 2016/11/10 at 14:44:08, ben wrote: > > ...
4 years, 1 month ago (2016-11-10 18:31:31 UTC) #5
Ben Goodger (Google)
4 years, 1 month ago (2016-11-10 18:33:41 UTC) #6
On 2016/11/10 18:31:31, Ben Goodger (Google) wrote:
> On 2016/11/10 15:07:43, Mike West wrote:
> > On 2016/11/10 at 14:44:08, ben wrote:
> > >
> >
>
https://codereview.chromium.org/2495523002/diff/1/services/service_manager/pu...
> > > File services/service_manager/public/cpp/lib/interface_registry.cc
(right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2495523002/diff/1/services/service_manager/pu...
> > > services/service_manager/public/cpp/lib/interface_registry.cc:210: VLOG(1)
> <<
> > ss.str();
> > > We should leave this one as LOG(ERROR). It's important for debugging
issues
> on
> > bots & pretty much anytime you see it it represents a catastrophic failure.
> > 
> > Can we be more aggressive, then? I've seen
> > https://bugs.chromium.org/p/chromium/issues/detail?id=664154 for at least a
> day
> > or two now; perhaps if we crashed (as it looks like we do if
> > `CanBindRequestForInterface` fails), folks would be more inclined to fix the
> > issue?
> 
> Possibly, yeah. I think I made this an error only out of habit of not wanting
to
> crash test suites on the first failure, but the suite runners these days
handle
> that.

Specifically, we should crash the client by calling ReportBadMessage the way we
do for a request blocked by spec below. We should not crash the server, because
that would allow a rogue client to trivially take down the browser.

Powered by Google App Engine
This is Rietveld 408576698