Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2495453002: [Chromoting] Remove screen_capturer.h & desktop_capturer.h (Closed)

Created:
4 years, 1 month ago by Hzj_jie
Modified:
4 years, 1 month ago
Reviewers:
Sergey Ulanov, Jamie
CC:
chromium-reviews, extensions-reviews_chromium.org, oshima+watch_chromium.org, chromoting-reviews_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Remove screen_capturer.h & desktop_capturer.h This change removes screen_capturer.h and desktop_capturer.h from Chromium, which blocks change https://codereview.chromium.org/2490063002/. BUG=webrtc:6513 Committed: https://crrev.com/a69c78443bceeb4444cd8083e2033c4895d94ab2 Cr-Commit-Position: refs/heads/master@{#431443}

Patch Set 1 #

Patch Set 2 : Include ipc_desktop_environment_unittest.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -19 lines) Patch
M chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/media/webrtc/native_desktop_media_list.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/media/webrtc/native_desktop_media_list_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/media/capture/desktop_capture_device_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/plugin/pepper_video_renderer_3d.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/basic_desktop_environment.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/chromeos/aura_desktop_capturer.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/desktop_capturer_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/desktop_session_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/ipc_desktop_environment.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/ipc_desktop_environment_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/me2me_desktop_environment.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/single_window_desktop_environment.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/session_desktop_environment.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (14 generated)
Hzj_jie
4 years, 1 month ago (2016-11-10 04:15:32 UTC) #7
Sergey Ulanov
I think you also want to update host/ipc_desktop_environment_unittest.cc Otherwise LGTM.
4 years, 1 month ago (2016-11-10 20:27:45 UTC) #8
Hzj_jie
On 2016/11/10 20:27:45, Sergey Ulanov wrote: > I think you also want to update host/ipc_desktop_environment_unittest.cc ...
4 years, 1 month ago (2016-11-10 21:44:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495453002/20001
4 years, 1 month ago (2016-11-10 23:19:27 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-11 01:29:35 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 01:33:07 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a69c78443bceeb4444cd8083e2033c4895d94ab2
Cr-Commit-Position: refs/heads/master@{#431443}

Powered by Google App Engine
This is Rietveld 408576698