Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: third_party/WebKit/Source/core/dom/Fullscreen.h

Issue 2495423004: Convert FullscreenController to use WebCallbacks (Closed)
Patch Set: just in case Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/BUILD.gn ('k') | third_party/WebKit/Source/core/dom/Fullscreen.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Fullscreen.h
diff --git a/third_party/WebKit/Source/core/dom/Fullscreen.h b/third_party/WebKit/Source/core/dom/Fullscreen.h
index f14a4b628374aa9fe36484277804bb323d3e62f7..db12cea5d9916c08f5ad800693ca928b585b3b35 100644
--- a/third_party/WebKit/Source/core/dom/Fullscreen.h
+++ b/third_party/WebKit/Source/core/dom/Fullscreen.h
@@ -92,9 +92,8 @@ class CORE_EXPORT Fullscreen final
: nullptr;
}
- // Called by FullscreenController to notify that we've entered or exited
- // fullscreen. All frames are notified, so there may be no pending request.
- void didEnterFullscreen();
+ // Called by FullscreenController to notify that we've exited fullscreen. All
+ // frames are notified, so there may be no fullscreen element.
void didExitFullscreen();
void setFullScreenLayoutObject(LayoutFullScreen*);
@@ -125,12 +124,16 @@ class CORE_EXPORT Fullscreen final
DECLARE_VIRTUAL_TRACE();
private:
+ friend class RequestFullscreenCallbacks;
+
static Fullscreen* fromIfExistsSlow(Document&);
explicit Fullscreen(Document&);
Document* document();
+ void didEnterFullscreen(Element&);
+
void clearFullscreenElementStack();
void popFullscreenElementStack();
void pushFullscreenElementStack(Element&, RequestType);
@@ -139,7 +142,6 @@ class CORE_EXPORT Fullscreen final
void enqueueErrorEvent(Element&, RequestType);
void eventQueueTimerFired(TimerBase*);
- Member<Element> m_pendingFullscreenElement;
HeapVector<std::pair<Member<Element>, RequestType>> m_fullscreenElementStack;
Member<Element> m_currentFullScreenElement;
LayoutFullScreen* m_fullScreenLayoutObject;
« no previous file with comments | « third_party/WebKit/Source/core/dom/BUILD.gn ('k') | third_party/WebKit/Source/core/dom/Fullscreen.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698