Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2495423004: Convert FullscreenController to use WebCallbacks (Closed)
Patch Set: public/WebFullscreenCallbacks->core/FullscreenCallbacks Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebViewImpl.h
diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h
index 9590b6379d7cb536c31b3b88a9273b844397dd88..fff07794ed5c6059b00c2e5b74db671e4184b91c 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.h
+++ b/third_party/WebKit/Source/web/WebViewImpl.h
@@ -75,6 +75,7 @@ class BrowserControls;
class DataObject;
class DevToolsEmulator;
class Frame;
+class FullscreenCallbacks;
class FullscreenController;
class InspectorOverlay;
class LinkHighlightImpl;
@@ -447,8 +448,8 @@ class WEB_EXPORT WebViewImpl final
return m_fakePageScaleAnimationUseAnchor;
}
- void enterFullscreenForElement(Element*);
- void exitFullscreen(LocalFrame*);
+ void enterFullscreen(LocalFrame&, std::unique_ptr<FullscreenCallbacks>);
+ void exitFullscreen(LocalFrame&);
void fullscreenElementChanged(Element*, Element*);
// Exposed for the purpose of overriding device metrics.
@@ -699,7 +700,7 @@ class WEB_EXPORT WebViewImpl final
WebGestureDevice m_flingSourceDevice;
Vector<std::unique_ptr<LinkHighlightImpl>> m_linkHighlights;
std::unique_ptr<CompositorAnimationTimeline> m_linkHighlightsTimeline;
- Persistent<FullscreenController> m_fullscreenController;
+ std::unique_ptr<FullscreenController> m_fullscreenController;
WebColor m_baseBackgroundColor;
WebColor m_backgroundColorOverride;

Powered by Google App Engine
This is Rietveld 408576698