Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2495423004: Convert FullscreenController to use WebCallbacks (Closed)
Patch Set: public/WebFullscreenCallbacks->core/FullscreenCallbacks Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
index 52377c67a1cc7f279db6a531351cb5155e6a0ede..2183dc219b62cdfe4a39205d074baeae72f23c75 100644
--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp
+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
@@ -36,6 +36,7 @@
#include "core/dom/AXObjectCache.h"
#include "core/dom/Document.h"
#include "core/dom/Fullscreen.h"
+#include "core/dom/FullscreenCallbacks.h"
#include "core/dom/Node.h"
#include "core/events/UIEventWithKeyState.h"
#include "core/frame/FrameHost.h"
@@ -851,11 +852,13 @@ void ChromeClientImpl::detachCompositorAnimationTimeline(
compositorTimeline);
}
-void ChromeClientImpl::enterFullscreenForElement(Element* element) {
- m_webView->enterFullscreenForElement(element);
+void ChromeClientImpl::enterFullscreen(
+ LocalFrame& frame,
+ std::unique_ptr<FullscreenCallbacks> callbacks) {
+ m_webView->enterFullscreen(frame, std::move(callbacks));
}
-void ChromeClientImpl::exitFullscreen(LocalFrame* frame) {
+void ChromeClientImpl::exitFullscreen(LocalFrame& frame) {
m_webView->exitFullscreen(frame);
}

Powered by Google App Engine
This is Rietveld 408576698