Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2495423004: Convert FullscreenController to use WebCallbacks (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index ccbc76e96dd0add32d5609f687d4adbdb966883f..ee572a85fc86dbcfd7d44170fd87f31913cc3a38 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -2073,11 +2073,13 @@ void WebViewImpl::themeChanged() {
view->invalidateRect(damagedRect);
}
-void WebViewImpl::enterFullscreenForElement(Element* element) {
- m_fullscreenController->enterFullscreenForElement(element);
+void WebViewImpl::enterFullscreen(
+ LocalFrame& frame,
+ std::unique_ptr<WebFullscreenCallbacks> callbacks) {
+ m_fullscreenController->enterFullscreen(frame, std::move(callbacks));
}
-void WebViewImpl::exitFullscreen(LocalFrame* frame) {
+void WebViewImpl::exitFullscreen(LocalFrame& frame) {
m_fullscreenController->exitFullscreen(frame);
}

Powered by Google App Engine
This is Rietveld 408576698