Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2495423004: Convert FullscreenController to use WebCallbacks (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
index 373e6d342b32af1fb2d2b6b32e373f37f38ccd93..4f5faecf6cb3bb40a47b2151d1c8823ecdf010b8 100644
--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp
+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
@@ -851,11 +851,13 @@ void ChromeClientImpl::detachCompositorAnimationTimeline(
compositorTimeline);
}
-void ChromeClientImpl::enterFullscreenForElement(Element* element) {
- m_webView->enterFullscreenForElement(element);
+void ChromeClientImpl::enterFullscreen(
+ LocalFrame& frame,
+ std::unique_ptr<WebFullscreenCallbacks> callbacks) {
+ m_webView->enterFullscreen(frame, std::move(callbacks));
}
-void ChromeClientImpl::exitFullscreen(LocalFrame* frame) {
+void ChromeClientImpl::exitFullscreen(LocalFrame& frame) {
m_webView->exitFullscreen(frame);
}

Powered by Google App Engine
This is Rietveld 408576698