third_party/WebKit/Source/core/dom/FullscreenCallbacks.h - Issue 2495423004: Convert FullscreenController to use WebCallbacks

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/dom/FullscreenCallbacks.h

Issue 2495423004: Convert FullscreenController to use WebCallbacks (Closed)

Patch Set: public/WebFullscreenCallbacks->core/FullscreenCallbacks Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef FullscreenCallbacks_h

	6 #define FullscreenCallbacks_h

	7

	8 namespace blink {

	9

	10 class FullscreenCallbacks {
	mlamouri (slow - plz ping) 2016/12/01 10:31:03 Any reason why you don't make this RequestFullscre Any reason why you don't make this RequestFullscreenCallbacks instead of having this interface that is used only once? foolip 2016/12/01 10:52:59 A remnant from when I used callbacks also for exit Show quoted text On 2016/12/01 10:31:03, mlamouri wrote: > Any reason why you don't make this RequestFullscreenCallbacks instead of having > this interface that is used only once? A remnant from when I used callbacks also for exiting. I may have to put that back, but if not I'll simplify as suggested.
	11 public:

	12 virtual ~FullscreenCallbacks() = default;

	13 virtual void onSuccess() = 0;

	14 virtual void onError() = 0;

	15 };

	16

	17 } // namespace blink

	18

	19 #endif // FullscreenCallbacks_h

OLD	NEW