third_party/WebKit/public/platform/WebFullscreenCallbacks.h - Issue 2495423004: Convert FullscreenController to use WebCallbacks

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/public/platform/WebFullscreenCallbacks.h

Issue 2495423004: Convert FullscreenController to use WebCallbacks (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef WebFullscreenCallbacks_h

	6 #define WebFullscreenCallbacks_h

	7

	8 #include "public/platform/WebCallbacks.h"

	9

	10 namespace blink {

	11

	12 using WebFullscreenCallbacks = WebCallbacks<void, void>;
	mlamouri (slow - plz ping) 2016/11/30 09:24:57 You are adding this to public/platform/ but you do You are adding this to public/platform/ but you don't seem to use it outside of Blink. What about exposing FullscreenCallbacks in core/ instead? It sounds that the current users will be able to access the header (from core/ and web/) and it will be slightly more straightforward. foolip 2016/11/30 10:23:52 Thanks, that's exactly the kind of feedback I was Show quoted text On 2016/11/30 09:24:57, mlamouri (OOO until 29-11) wrote: > You are adding this to public/platform/ but you don't seem to use it outside of > Blink. What about exposing FullscreenCallbacks in core/ instead? It sounds that > the current users will be able to access the header (from core/ and web/) and it > will be slightly more straightforward. Thanks, that's exactly the kind of feedback I was looking for. Maybe a Fullscreen::PendingRequest or something, I'll experiment a bit.
	13

	14 } // namespace blink

	15

	16 #endif // WebFullscreenCallbacks_h

OLD	NEW