Issue 2495403003: getResult() should not try to compute for non-Dart files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2495403003: getResult() should not try to compute for non-Dart files. (Closed)

Created:
4 years, 1 month ago by scheglov

Modified:
4 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -9 lines)			Patch
	M	pkg/analyzer/lib/src/dart/analysis/driver.dart	View		2 chunks	+13 lines, -9 lines	0 comments	Download
	M	pkg/analyzer/test/src/dart/analysis/driver_test.dart	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Brian Wilkerson

Unfortunately, there is a small wrinkle here. The DLS does not state that Dart source ...

4 years, 1 month ago (2016-11-14 19:07:23 UTC) #2

scheglov

4 years, 1 month ago (2016-11-14 19:16:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
36f623ab1ca493c59fba2e75f7f581d51a25bff5 (presubmit successful).