Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 24954002: Generate toCSSFooValue for CSSFunctionValue and CSSSVGDocumentValue (Closed)

Created:
7 years, 2 months ago by gyuyoung-inactive
Modified:
7 years, 2 months ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Generate toCSSFooValue for CSSFunctionValue and CSSSVGDocumentValue toCSSFooValue() will help to detect bad-casts as well as improve readibility. To use DEFINE_CSS_VALUE_TYPE_CASTS, *CSS* is removed from isCSSSVGDocument() as well as remove existing manual type cast functions. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158419

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -19 lines) Patch
M Source/core/css/CSSFunctionValue.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/css/CSSSVGDocumentValue.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSValue.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/FilterOperationResolver.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
gyuyoung-inactive
new patch to remove static_cast<CSS*Value>
7 years, 2 months ago (2013-09-27 04:04:14 UTC) #1
tkent
lgtm
7 years, 2 months ago (2013-09-27 04:12:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/24954002/1
7 years, 2 months ago (2013-09-27 04:13:00 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 2 months ago (2013-09-27 06:03:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/24954002/1
7 years, 2 months ago (2013-09-27 06:04:44 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-09-27 06:05:01 UTC) #6
Message was sent while issue was closed.
Change committed as 158419

Powered by Google App Engine
This is Rietveld 408576698