ValueSerializer: Don't throw an exception after SetPropertiesFromKeyValuePairs fails.

ValueSerializer: Don't throw an exception after SetPropertiesFromKeyValuePairs fails.

It always throws an exception in the cases that it fails, so throwing another
doesn't help things.

BUG=chromium:664416
Committed: https://crrev.com/054e17796df10ed65e0381691ab092794f9aee2e
Cr-Commit-Position: refs/heads/master@{#40999}

[jbroman, 2016-11-14 18:49:52]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 18:50:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 19:14:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 19:14:53]

Dry run: This issue passed the CQ dry run.

[jbroman, 2016-11-14 19:15:15]

Description was changed from

==========
ValueSerializer: Don't throw an exception after SetPropertiesFromKeyValuePairs
fails.

It always throws an exception in the cases that it fails, so throwing another
doesn't help things.

BUG=664416
==========

to

==========
ValueSerializer: Don't throw an exception after SetPropertiesFromKeyValuePairs
fails.

It always throws an exception in the cases that it fails, so throwing another
doesn't help things.

BUG=chromium:664416
==========

[jbroman, 2016-11-14 19:16:12]

jbroman@chromium.org changed reviewers:
+ jkummerow@chromium.org

[jbroman, 2016-11-14 19:16:12]

That function can only fail if LookupIterator::PropertyOrElement fails or
JSObject::DefineOwnPropertyIgnoreAttributes fails. In either case, the runtime
already throws an exception.

[Jakob Kummerow, 2016-11-15 10:05:02]

lgtm

[jbroman, 2016-11-15 15:14:19]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2016-11-15 15:14:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 15:16:29]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-17 22:34:26]

Description was changed from

==========
ValueSerializer: Don't throw an exception after SetPropertiesFromKeyValuePairs
fails.

It always throws an exception in the cases that it fails, so throwing another
doesn't help things.

BUG=chromium:664416
==========

to

==========
ValueSerializer: Don't throw an exception after SetPropertiesFromKeyValuePairs
fails.

It always throws an exception in the cases that it fails, so throwing another
doesn't help things.

BUG=chromium:664416

Committed: https://crrev.com/054e17796df10ed65e0381691ab092794f9aee2e
Cr-Commit-Position: refs/heads/master@{#40999}
==========

[commit-bot: I haz the power, 2016-11-17 22:34:27]

Patchset 1 (id:??) landed as
https://crrev.com/054e17796df10ed65e0381691ab092794f9aee2e
Cr-Commit-Position: refs/heads/master@{#40999}