Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: tests/isolate/browser/package_resolve_browser_hook_test.dart

Issue 2495383003: Add implementation of Isolate.resolvePackageUri for dart2js. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/isolate/browser/package_resolve_browser_hook_test.dart
diff --git a/tests/isolate/browser/package_resolve_browser_hook_test.dart b/tests/isolate/browser/package_resolve_browser_hook_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..32683e85e51bd52da744ffeb46602b701a901bd2
--- /dev/null
+++ b/tests/isolate/browser/package_resolve_browser_hook_test.dart
@@ -0,0 +1,13 @@
+// Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'dart:isolate';
+import 'package:unittest/unittest.dart';
+
+final PACKAGE_URI = "package:foo/bar.txt";
Lasse Reichstein Nielsen 2016/11/14 20:42:34 Nitpick: Style guide says to use camelCase for con
Siggi Cherem (dart-lang) 2016/11/14 23:07:15 haha - good point, I just copied it from a differe
+
+main() async {
Lasse Reichstein Nielsen 2016/11/14 20:42:34 Are you sure an async main works with the test run
Siggi Cherem (dart-lang) 2016/11/14 23:07:15 Good point, should be fixed now.
+ var uri = await Isolate.resolvePackageUri(Uri.parse(PACKAGE_URI));
+ expect(uri, Uri.base.resolve('path_set_from_hook/foo/bar.txt'));
Harry Terkelsen 2016/11/14 22:27:23 can we also test if the hook is set to a path with
Siggi Cherem (dart-lang) 2016/11/14 23:07:15 Done.
+}

Powered by Google App Engine
This is Rietveld 408576698