chrome/browser/resources/chromeos/chromevox/tools/check_chromevox.py - Issue 2495373005: Record ChromeVox metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/tools/check_chromevox.py

Issue 2495373005: Record ChromeVox metrics (Closed)

Patch Set: Rename 'Accessibility.' and clarify Next Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2 ('k') | tools/metrics/actions/actions.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/tools/check_chromevox.py

diff --git a/chrome/browser/resources/chromeos/chromevox/tools/check_chromevox.py b/chrome/browser/resources/chromeos/chromevox/tools/check_chromevox.py

index 1b2adab95afa33674e2bc18036fc13e1175da929..91a5de3b356ddf23b250b625b55b57a19eda2a71 100755

--- a/chrome/browser/resources/chromeos/chromevox/tools/check_chromevox.py

+++ b/chrome/browser/resources/chromeos/chromevox/tools/check_chromevox.py

@@ -45,6 +45,11 @@ def ChromeRootPath(path='.'):

_CHROME_EXTENSIONS_EXTERNS = (

ChromeRootPath('third_party/closure_compiler/externs/chrome_extensions.js'))

+# MetricsPrivate externs file.

+_METRICS_PRIVATE_EXTERNS = (

+ ChromeRootPath('third_party/closure_compiler/externs/metrics_private.js'))

# Externs common to many ChromeVox scripts.

_COMMON_EXTERNS = [

CVoxPath('common/externs.js'),

@@ -52,7 +57,8 @@ _COMMON_EXTERNS = [

CVoxPath('chromevox/background/externs.js'),

CVoxPath('chromevox/injected/externs.js'),

CVoxPath('host/chrome/externs.js'),

- _CHROME_EXTENSIONS_EXTERNS]

+ _CHROME_EXTENSIONS_EXTERNS,

+ _METRICS_PRIVATE_EXTERNS]

# List of top-level scripts and externs that we can check.

_TOP_LEVEL_SCRIPTS = [