MD Settings: Fix Search tooltip arrow obscuring letters

MD Settings: Fix Search tooltip arrow obscuring letters

The arrow for the search bubbles is rendering on top of the text. This
blocks parts of the letter for letters like 'y' or 'j', when the tooltip
is in the "above" position.

This CL adds a z-index to put the arrow behind the letters, which is the
same solution that Old Options used.

BUG=664074
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/8cc356c754f7f9632c538b0f7318e42d97573ad0
Cr-Commit-Position: refs/heads/master@{#432054}

[tommycli, 2016-11-14 22:39:34]

Description was changed from

==========
MD Settings: Fix Search tooltip arrow obscuring letters

The arrow for the search bubbles is rendering on top of the text. This
blocks parts of the letter for letters like 'y' or 'j', when the tooltip
is in the "above" position.

This CL adds a z-index to put the arrow behind the letters, which is the
same solution that Old Options used.

BUG=664074
==========

to

==========
MD Settings: Fix Search tooltip arrow obscuring letters

The arrow for the search bubbles is rendering on top of the text. This
blocks parts of the letter for letters like 'y' or 'j', when the tooltip
is in the "above" position.

This CL adds a z-index to put the arrow behind the letters, which is the
same solution that Old Options used.

BUG=664074
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-11-14 22:39:46]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[tommycli, 2016-11-14 22:40:21]

tommycli@chromium.org changed reviewers:
+ dpapad@chromium.org

[tommycli, 2016-11-14 22:40:22]

dpapad: PTAL,

I have tested that this z-index modification does not negatively affect dialogs
and the right sidebar. (The search bubble is still behind those items).

See bug for screenshot of the problem.

Tommy

[tommycli, 2016-11-14 22:40:40]

On 2016/11/14 22:40:22, tommycli wrote:
> dpapad: PTAL,
> 
> I have tested that this z-index modification does not negatively affect
dialogs
> and the right sidebar. (The search bubble is still behind those items).
> 
> See bug for screenshot of the problem.
> 
> Tommy

Here is the corresponding code in Old Options:
https://cs.chromium.org/chromium/src/chrome/browser/resources/print_preview/c...

[commit-bot: I haz the power, 2016-11-14 22:41:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-11-14 23:26:30]

lgtm

[tommycli, 2016-11-14 23:31:27]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-11-14 23:31:28]

The CQ bit was unchecked by tommycli@chromium.org

[tommycli, 2016-11-15 00:32:00]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-11-15 00:33:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 01:53:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-15 01:56:56]

Description was changed from

==========
MD Settings: Fix Search tooltip arrow obscuring letters

The arrow for the search bubbles is rendering on top of the text. This
blocks parts of the letter for letters like 'y' or 'j', when the tooltip
is in the "above" position.

This CL adds a z-index to put the arrow behind the letters, which is the
same solution that Old Options used.

BUG=664074
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix Search tooltip arrow obscuring letters

The arrow for the search bubbles is rendering on top of the text. This
blocks parts of the letter for letters like 'y' or 'j', when the tooltip
is in the "above" position.

This CL adds a z-index to put the arrow behind the letters, which is the
same solution that Old Options used.

BUG=664074
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/8cc356c754f7f9632c538b0f7318e42d97573ad0
Cr-Commit-Position: refs/heads/master@{#432054}
==========

[commit-bot: I haz the power, 2016-11-15 01:56:57]

Patchset 1 (id:??) landed as
https://crrev.com/8cc356c754f7f9632c538b0f7318e42d97573ad0
Cr-Commit-Position: refs/heads/master@{#432054}