chrome.webRequest support for ExtensionSettings

url/origin.cc

Index: url/origin.cc
diff --git a/url/origin.cc b/url/origin.cc
index d15ba43f8f64f196e47fd540c3e15632c5c3a61a..087dde77a57c5768d3d5764ff65adee8c2463d12 100644
--- a/url/origin.cc
+++ b/url/origin.cc
@@ -159,6 +159,18 @@ GURL Origin::GetURL() const {
   return tuple_url;
 }
 
+GURL Origin::GetURLWithoutSuborigin() const {
+  if (unique())
+    return GURL();
+
+  if (scheme() == kFileScheme)
+    return GURL("file:///");
+
+  GURL tuple_url(tuple_.GetURL());
+
+  return tuple_url;
+}

[Mike West, 2017/05/26 11:45:35]

+Jochen, who's responsible for suborigins these days.

What should we do here? It does seem like extensions' permission grants
shouldn't care about suborigins, but adding this kind of accessor just to get
around the serialization differences feels strange. We have a
`ToPhysicalOriginString()` on `blink::SecurityOrigin`, which we use for
`postMessage()`. Should we replicate that here? I'd prefer not to if we can get
away without it.

[jochen (gone - plz use gerrit), 2017/05/26 11:51:53]

why not use origin->GetPhysicalOrigin().GetURL() ?

[nrpeter, 2017/05/26 15:50:24]

Good point, I'll switch to GetPhysicalOrigin().GetURL() as that should be
equivalent.

+
 bool Origin::IsSameOriginWith(const Origin& other) const {
   if (unique_ || other.unique_)
     return false;