chrome.webRequest support for ExtensionSettings

url/origin.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "url/origin.h"
 
 #include <stdint.h>
 #include <string.h>
 
 #include "base/logging.h"
@@ skipping 141 matching lines @@
     return GURL("file:///");
 
   GURL tuple_url(tuple_.GetURL());
 
   if (!suborigin_.empty())
     return AddSuboriginToUrl(tuple_url, suborigin_);
 
   return tuple_url;
 }
 
+GURL Origin::GetURLWithoutSuborigin() const {
+  if (unique())
+    return GURL();
+
+  if (scheme() == kFileScheme)
+    return GURL("file:///");
+
+  GURL tuple_url(tuple_.GetURL());
+
+  return tuple_url;
+}

[Mike West, 2017/05/26 11:45:35]

+Jochen, who's responsible for suborigins these days.

What should we do here? It does seem like extensions' permission grants
shouldn't care about suborigins, but adding this kind of accessor just to get
around the serialization differences feels strange. We have a
`ToPhysicalOriginString()` on `blink::SecurityOrigin`, which we use for
`postMessage()`. Should we replicate that here? I'd prefer not to if we can get
away without it.

[jochen (gone - plz use gerrit), 2017/05/26 11:51:53]

why not use origin->GetPhysicalOrigin().GetURL() ?

[nrpeter, 2017/05/26 15:50:24]

Good point, I'll switch to GetPhysicalOrigin().GetURL() as that should be
equivalent.

+
 bool Origin::IsSameOriginWith(const Origin& other) const {
   if (unique_ || other.unique_)
     return false;
 
   return tuple_.Equals(other.tuple_) && suborigin_ == other.suborigin_;
 }
 
 bool Origin::IsSamePhysicalOriginWith(const Origin& other) const {
   return GetPhysicalOrigin().IsSameOriginWith(other.GetPhysicalOrigin());
 }
@@ skipping 13 matching lines @@
 
 bool IsSameOriginWith(const GURL& a, const GURL& b) {
   return Origin(a).IsSameOriginWith(Origin(b));
 }
 
 bool IsSamePhysicalOriginWith(const GURL& a, const GURL& b) {
   return Origin(a).IsSamePhysicalOriginWith(Origin(b));
 }
 
 }  // namespace url