chrome.webRequest support for ExtensionSettings

extensions/browser/api/web_request/web_request_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/web_request/web_request_api.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <memory>
@@ skipping 1481 matching lines @@
         std::find(types.begin(), types.end(), resource_type) == types.end()) {
       continue;
     }
 
     if (!is_web_view_guest) {
       PermissionsData::AccessType access =
           WebRequestPermissions::CanExtensionAccessURL(
               extension_info_map, listener->id.extension_id, url,
               frame_data.tab_id, crosses_incognito,
               WebRequestPermissions::REQUIRE_HOST_PERMISSION);
+
+      // Check if URL blocked from view/modification due to a policy protected
+      // origin.
+      if (extension_info_map) {
+        const extensions::Extension* extension =
+            extension_info_map->extensions().GetByID(listener->id.extension_id);

[Devlin, 2017/05/25 20:38:32]

Can we just put this in WebRequestPermissions::CanExtensionAccessURL?

[nrpeter, 2017/05/26 02:46:52]

I would like to but doing so would change the behavior of existing extensions
regardless of whether they are using the ExtensionSettings policy. 

It may be helpful to re-read #17 & #21

[Devlin, 2017/06/01 15:21:32]

I'm suggesting putting the entire block, including the IsRuntimeBlockedHost()
check, in WebRequestPermissions.  How would that change behavior?

[nrpeter, 2017/06/06 21:42:07]

Done.

+        if (request->initiator() &&
+            extension->permissions_data()->IsRuntimeBlockedHost(
+                request->initiator()->GetURLWithoutSuborigin()))
+          access = PermissionsData::ACCESS_DENIED;
+      }
+
       if (access != PermissionsData::ACCESS_ALLOWED) {
         if (access == PermissionsData::ACCESS_WITHHELD &&
             web_request_event_router_delegate_) {
           web_request_event_router_delegate_->NotifyWebRequestWithheld(
               render_process_id, render_frame_id, listener->id.extension_id);
         }
         continue;
       }
     }
 
@@ skipping 932 matching lines @@
   // Since EventListeners are segmented by browser_context, check that
   // last, as it is exceedingly unlikely to be different.
   return extension_id == that.extension_id &&
          sub_event_name == that.sub_event_name &&
          web_view_instance_id == that.web_view_instance_id &&
          embedder_process_id == that.embedder_process_id &&
          browser_context == that.browser_context;
 }
 
 }  // namespace extensions