Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2495343002: Revert of Paint collapsed borders of a table as one display item (Closed)

Created:
4 years, 1 month ago by Xianzhu
Modified:
4 years, 1 month ago
Reviewers:
chrishtr, wkorman
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Paint collapsed borders of a table as one display item (patchset #10 id:180001 of https://codereview.chromium.org/2430313004/ ) Reason for revert: Caused bug 664887. We miss invalidation of collapsed borders when they are changed by layout. BUG=664887 Original issue's description: > Paint collapsed borders of a table as one display item > > This simplifies paint invalidation logic on collapsed border changes. > > About performance: > With this CL we create a big display item on the table containing all > collapsed border paintings, instead of many small display items on cells. > This will cause more painting when the display item is invalidated, but > saves time to handle many cached display items. Perf try jobs [1] show > that this CL actually improves performance of one test > (blink_perf.paint.large-table-background-change-with-invisible-collapsed-borders.html), > and doesn't affect much of performance of other tests. > Cluster-telemetry run showed no change or slight progression [2]. > > [1] https://codereview.chromium.org/2430313004/#ps60001 > [2] https://ct.skia.org/chromium_perf_runs/, run 1433 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > BUG=663208 > > Committed: https://crrev.com/c5cc11e88930c6e3f5e08b330fb14b6b571a0404 > Cr-Commit-Position: refs/heads/master@{#431744} TBR=chrishtr@chromium.org,wkorman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=663208 Committed: https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9 Cr-Commit-Position: refs/heads/master@{#431903}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+582 lines, -566 lines) Patch
M third_party/WebKit/LayoutTests/paint/invalidation/table-cell-collapsed-border-expected.txt View 2 chunks +42 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table-outer-border-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/border-collapse-change-separate-to-collapse-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/cached-cell-append-expected.txt View 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-cell-border-color-expected.txt View 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-cell-border-width-expected.txt View 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-col-border-color-expected.txt View 2 chunks +14 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-col-border-width-expected.txt View 2 chunks +14 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-colgroup-border-color-expected.txt View 2 chunks +22 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-colgroup-border-width-expected.txt View 2 chunks +22 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-row-border-width-expected.txt View 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-table-border-color-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-table-border-width-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-tbody-border-width-expected.txt View 2 chunks +22 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/table/composited-cell-change-collapsed-border-color.html View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/table/composited-cell-change-collapsed-border-color-expected.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/table/composited-cell-change-collapsed-border-color-expected.txt View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/table/composited-row-change-collapsed-border-color.html View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/table/composited-row-change-collapsed-border-color-expected.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/table/composited-row-change-collapsed-border-color-expected.txt View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/table/composited-section-change-collapsed-border-color.html View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/table/composited-section-change-collapsed-border-color-expected.html View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/table/composited-section-change-collapsed-border-color-expected.txt View 1 chunk +0 lines, -41 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table-cell-collapsed-border-expected.txt View 2 chunks +42 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table-collapsed-border-expected.txt View 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/cached-change-cell-sl-border-color-expected.txt View 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table-collapsed-border-expected.txt View 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table/cached-change-cell-sl-border-color-expected.txt View 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table-collapsed-border-expected.txt View 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table/cached-change-cell-sl-border-color-expected.txt View 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.h View 4 chunks +5 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 4 chunks +8 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.h View 5 chunks +35 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.cpp View 4 chunks +83 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.h View 3 chunks +5 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableCellPainter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableCellPainter.cpp View 4 chunks +50 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableCellPainterTest.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TablePainter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TablePainter.cpp View 1 chunk +19 lines, -49 lines 0 comments Download
D third_party/WebKit/Source/core/paint/TablePainterTest.cpp View 1 chunk +0 lines, -75 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableSectionPainter.h View 3 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableSectionPainter.cpp View 3 chunks +8 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h View 2 chunks +22 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp View 2 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Xianzhu
Created Revert of Paint collapsed borders of a table as one display item
4 years, 1 month ago (2016-11-14 17:00:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495343002/1
4 years, 1 month ago (2016-11-14 17:02:27 UTC) #3
chrishtr
lgtm
4 years, 1 month ago (2016-11-14 17:19:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 19:28:24 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 20:10:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9
Cr-Commit-Position: refs/heads/master@{#431903}

Powered by Google App Engine
This is Rietveld 408576698