Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 249533003: Support evaluation of expressions in context of a stack frame (Closed)

Created:
6 years, 8 months ago by hausner
Modified:
6 years, 8 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org, devoncarew, Jacob
Visibility:
Public.

Description

Support evaluation of expressions in context of a stack frame This change adds a debugger API function to evaluate an expression in the context of a particular stack frame. The expression can refer to local variables accessible in the frame, but it cannot alter the variables. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=35340

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -41 lines) Patch
M runtime/bin/dbg_message.cc View 1 3 chunks +30 lines, -9 lines 0 comments Download
M runtime/include/dart_debugger_api.h View 1 2 chunks +11 lines, -1 line 0 comments Download
M runtime/lib/mirrors.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/compiler_test.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/debugger.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/debugger.cc View 1 1 chunk +55 lines, -0 lines 0 comments Download
M runtime/vm/debugger_api_impl.cc View 1 2 chunks +26 lines, -4 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 chunks +20 lines, -5 lines 0 comments Download
M runtime/vm/object.cc View 1 7 chunks +49 lines, -17 lines 0 comments Download
M runtime/vm/service.cc View 1 3 chunks +10 lines, -3 lines 0 comments Download
M tools/ddbg.dart View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hausner
6 years, 8 months ago (2014-04-23 22:14:57 UTC) #1
regis
LGTM
6 years, 8 months ago (2014-04-23 22:48:45 UTC) #2
hausner
Thank you.
6 years, 8 months ago (2014-04-23 22:53:45 UTC) #3
hausner
6 years, 8 months ago (2014-04-23 22:56:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r35340 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698