Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issue 2495293002: Revert of [ast] Simplify FetchFreeVariables. (Closed)

Created:
4 years, 1 month ago by neis
Modified:
4 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, adamk
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [ast] Simplify FetchFreeVariables. (patchset #1 id:1 of https://codereview.chromium.org/2491373004/ ) Reason for revert: It's probably needed after all but we're lacking tests. Original issue's description: > [ast] Simplify FetchFreeVariables. > > This CL removes the ParseInfo argument from FetchFreeVariables, since it seems > to have become unnecessary. > > R=verwaest@chromium.org > BUG= TBR=verwaest@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/8538143c61664a6859e5f24374936b9e9edc92ce Cr-Commit-Position: refs/heads/master@{#40964}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M src/ast/scopes.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ast/scopes.cc View 4 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
neis
Created Revert of [ast] Simplify FetchFreeVariables.
4 years, 1 month ago (2016-11-14 12:55:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495293002/1
4 years, 1 month ago (2016-11-14 12:55:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 13:22:44 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:32:33 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8538143c61664a6859e5f24374936b9e9edc92ce
Cr-Commit-Position: refs/heads/master@{#40964}

Powered by Google App Engine
This is Rietveld 408576698