Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2495273002: Get rid of "default:" clause. (Closed)

Created:
4 years, 1 month ago by hidehiko
Modified:
4 years, 1 month ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, khmel+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of "default:" clause. With this change, if a new value is missing in the switch state, compiler warns it. BUG=n/a TEST=Ran trybots. Made sure compiler's error if an value is missing in the switch statement. Committed: https://crrev.com/5e6c0490f2fb7cd7478dabec235a0f1cfa19178a Cr-Commit-Position: refs/heads/master@{#431905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/chromeos/arc/arc_auth_service.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
hidehiko
PTAL.
4 years, 1 month ago (2016-11-14 10:50:47 UTC) #4
Luis Héctor Chávez
lgtm Thanks!
4 years, 1 month ago (2016-11-14 16:09:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495273002/1
4 years, 1 month ago (2016-11-14 16:10:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 19:30:53 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 20:10:14 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e6c0490f2fb7cd7478dabec235a0f1cfa19178a
Cr-Commit-Position: refs/heads/master@{#431905}

Powered by Google App Engine
This is Rietveld 408576698