Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2495213008: Ship ImageBitmapRenderingContext (Closed)

Created:
4 years, 1 month ago by xidachen
Modified:
4 years, 1 month ago
CC:
blink-reviews, chromium-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ship ImageBitmapRenderingContext We have 3 lgtms from API owners: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/toKFfP_oOac Let's ship it! BUG=658734 Committed: https://crrev.com/3c50f35f90524844e9f69bc19bd05a0dd34351d5 Cr-Commit-Position: refs/heads/master@{#432224}

Patch Set 1 #

Patch Set 2 : update layout test results #

Patch Set 3 : change virtual stable #

Patch Set 4 : change win platform #

Messages

Total messages: 20 (10 generated)
xidachen
PTAL
4 years, 1 month ago (2016-11-15 14:35:54 UTC) #2
Justin Novosad
lgtm
4 years, 1 month ago (2016-11-15 15:27:39 UTC) #3
chrishtr
lgtm
4 years, 1 month ago (2016-11-15 16:31:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495213008/60001
4 years, 1 month ago (2016-11-15 16:32:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/317352)
4 years, 1 month ago (2016-11-15 17:17:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495213008/60001
4 years, 1 month ago (2016-11-15 18:39:42 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-15 18:51:13 UTC) #15
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/3c50f35f90524844e9f69bc19bd05a0dd34351d5 Cr-Commit-Position: refs/heads/master@{#432224}
4 years, 1 month ago (2016-11-15 19:05:50 UTC) #17
vabr (Chromium)
Did you really mean to associate this with http://crbug.com/658732?
4 years, 1 month ago (2016-11-16 08:18:31 UTC) #18
xidachen
4 years, 1 month ago (2016-11-16 12:57:42 UTC) #19
Message was sent while issue was closed.
On 2016/11/16 08:18:31, vabr (travelling until 21 Nov) wrote:
> Did you really mean to associate this with http://crbug.com/658732

It was a typo, it is supposed to be 658734...

Powered by Google App Engine
This is Rietveld 408576698