[Extensions] Use a separate IPC message for extension events

extensions/browser/event_router.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/event_router.h"
 
 #include <stddef.h>
 
 #include <tuple>
 #include <utility>
@@ skipping 85 matching lines @@
                                            void* browser_context_id,
                                            const std::string& extension_id,
                                            int event_id,
                                            const std::string& event_name,
                                            ListValue* event_args,
                                            UserGestureState user_gesture,
                                            const EventFilteringInfo& info) {
   NotifyEventDispatched(browser_context_id, extension_id, event_name,
                         *event_args);
 
-  // TODO(chirantan): Make event dispatch a separate IPC so that it doesn't
-  // piggyback off MessageInvoke, which is used for other things.
-  ListValue args;
-  args.Set(0, new base::StringValue(event_name));
-  args.Set(1, event_args);
-  args.Set(2, info.AsValue().release());
-  args.Set(3, new base::FundamentalValue(event_id));
-  ipc_sender->Send(new ExtensionMsg_MessageInvoke(
-      MSG_ROUTING_CONTROL,
-      extension_id,
-      kEventBindings,
-      "dispatchEvent",
-      args,
-      user_gesture == USER_GESTURE_ENABLED));
+  ExtensionMsg_DispatchEvent_Params params;
+  params.extension_id = extension_id;
+  params.event_name = event_name;
+  params.event_id = event_id;
+  params.is_user_gesture = user_gesture == USER_GESTURE_ENABLED;
+  params.filtering_info.Swap(info.AsValue().get());
 
-  // DispatchExtensionMessage does _not_ take ownership of event_args, so we
-  // must ensure that the destruction of args does not attempt to free it.
-  std::unique_ptr<base::Value> removed_event_args;
-  args.Remove(1, &removed_event_args);
-  ignore_result(removed_event_args.release());
+  ipc_sender->Send(new ExtensionMsg_DispatchEvent(params, *event_args));
 }
 
 // static
 EventRouter* EventRouter::Get(content::BrowserContext* browser_context) {
   return EventRouterFactory::GetForBrowserContext(browser_context);
 }
 
 // static
 std::string EventRouter::GetBaseEventName(const std::string& full_event_name) {
   size_t slash_sep = full_event_name.find('/');
@@ skipping 758 matching lines @@
                                      const std::string& extension_id,
                                      const GURL& listener_url,
                                      content::BrowserContext* browser_context)
     : event_name(event_name),
       extension_id(extension_id),
       listener_url(listener_url),
       browser_context(browser_context) {
 }
 
 }  // namespace extensions