[serializer] print use count of external references.

[serializer] print use count of external references.

R=peria@chromium.org, vogelheim@chromium.org
BUG=chromium:617892
NOPRESUBMIT=true

Committed: https://crrev.com/f0b21ef72cf390f417562f64f15cd3e63a14ae04
Cr-Commit-Position: refs/heads/master@{#40981}

[vogelheim, 2016-11-14 11:09:36]

lgtm

https://codereview.chromium.org/2495213003/diff/1/src/external-reference-tabl...
File src/external-reference-table.cc (right):

https://codereview.chromium.org/2495213003/diff/1/src/external-reference-tabl...
src/external-reference-table.cc:62: 
super nitpick: No empty line here. :-)

https://codereview.chromium.org/2495213003/diff/1/src/external-reference-tabl...
src/external-reference-table.cc:69: #endif  // SYMBOLIZE_FUNCTION
Nitpick: Does this even compile if SYMBOLIZE_FUNCTION is set? I think (some?)
compilers will balk at "return; return;". (With "balk" == warn; but we usually
have turn-warnings-into-errors enabled.) Maybe turn into #ifdef-#else-#endif?

https://codereview.chromium.org/2495213003/diff/1/src/external-reference-tabl...
src/external-reference-table.cc:380: Add(getters[i].address, getters[i].name +
12);
Huh? Why .name + 12?

https://codereview.chromium.org/2495213003/diff/1/src/external-reference-tabl...
src/external-reference-table.cc:380: Add(getters[i].address, getters[i].name +
12);
Ah... the assert in serialize-common.cc explains it... you're omitting the
"Redirect to " bit from the name constant. I think the code is correct, but it's
certainly non-obvious. :-/

[Yang, 2016-11-14 11:45:05]

Addressed comments.

https://codereview.chromium.org/2495213003/diff/1/src/external-reference-tabl...
File src/external-reference-table.cc (right):

https://codereview.chromium.org/2495213003/diff/1/src/external-reference-tabl...
src/external-reference-table.cc:62: 
On 2016/11/14 11:09:36, vogelheim wrote:
> super nitpick: No empty line here. :-)

Done.

https://codereview.chromium.org/2495213003/diff/1/src/external-reference-tabl...
src/external-reference-table.cc:69: #endif  // SYMBOLIZE_FUNCTION
On 2016/11/14 11:09:36, vogelheim wrote:
> Nitpick: Does this even compile if SYMBOLIZE_FUNCTION is set? I think (some?)
> compilers will balk at "return; return;". (With "balk" == warn; but we usually
> have turn-warnings-into-errors enabled.) Maybe turn into #ifdef-#else-#endif?

Done.

https://codereview.chromium.org/2495213003/diff/1/src/external-reference-tabl...
src/external-reference-table.cc:380: Add(getters[i].address, getters[i].name +
12);
On 2016/11/14 11:09:36, vogelheim wrote:
> Ah... the assert in serialize-common.cc explains it... you're omitting the
> "Redirect to " bit from the name constant. I think the code is correct, but
it's
> certainly non-obvious. :-/

Added a comment.

[Yang, 2016-11-14 11:45:10]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 11:45:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 11:49:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 11:49:11]

Dry run: Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/28447)

[peria, 2016-11-15 01:59:24]

LGTM

Thank you!! This seems very useful to optimize the snapshot.

[Yang, 2016-11-15 06:28:13]

Description was changed from

==========
[serializer] print use count of external references.

R=peria@chromium.org, vogelheim@chromium.org
BUG=chromium:617892
==========

to

==========
[serializer] print use count of external references.

R=peria@chromium.org, vogelheim@chromium.org
BUG=chromium:617892
NOPRESUBMIT=true
==========

[Yang, 2016-11-15 06:29:05]

On 2016/11/15 01:59:24, peria wrote:
> LGTM
> 
> Thank you!! This seems very useful to optimize the snapshot.

Ha.

If I do `git cl format`, the presubmit script complains that the indentation is
not a multiple of 2. If I don't, presubmit complains that I did not format.

[Yang, 2016-11-15 06:29:08]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-11-15 06:29:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2495213003/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2016-11-15 06:29:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 06:29:45]

Description was changed from

==========
[serializer] print use count of external references.

R=peria@chromium.org, vogelheim@chromium.org
BUG=chromium:617892
NOPRESUBMIT=true
==========

to

==========
[serializer] print use count of external references.

R=peria@chromium.org, vogelheim@chromium.org
BUG=chromium:617892
NOPRESUBMIT=true
==========

[commit-bot: I haz the power, 2016-11-15 06:29:46]

Committed patchset #2 (id:20001)

[Michael Achenbach, 2016-11-15 07:42:44]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2498163003/ by machenbach@chromium.org.

The reason for reverting is: Breaks
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20vtunejit/bui...
compile.

[Yang, 2016-11-15 07:57:54]

Description was changed from

==========
[serializer] print use count of external references.

R=peria@chromium.org, vogelheim@chromium.org
BUG=chromium:617892
NOPRESUBMIT=true
==========

to

==========
[serializer] print use count of external references.

R=peria@chromium.org, vogelheim@chromium.org
BUG=chromium:617892
NOPRESUBMIT=true
==========

[Yang, 2016-11-15 08:00:13]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-11-15 08:00:14]

The patchset sent to the CQ was uploaded after l-g-t-m from peria@chromium.org,
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2495213003/#ps40001
(title: "fix build")

[commit-bot: I haz the power, 2016-11-15 08:00:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 08:58:59]

Description was changed from

==========
[serializer] print use count of external references.

R=peria@chromium.org, vogelheim@chromium.org
BUG=chromium:617892
NOPRESUBMIT=true
==========

to

==========
[serializer] print use count of external references.

R=peria@chromium.org, vogelheim@chromium.org
BUG=chromium:617892
NOPRESUBMIT=true
==========

[commit-bot: I haz the power, 2016-11-15 08:59:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-17 22:33:23]

Description was changed from

==========
[serializer] print use count of external references.

R=peria@chromium.org, vogelheim@chromium.org
BUG=chromium:617892
NOPRESUBMIT=true
==========

to

==========
[serializer] print use count of external references.

R=peria@chromium.org, vogelheim@chromium.org
BUG=chromium:617892
NOPRESUBMIT=true

Committed: https://crrev.com/e56bd9c332c5b315c18af1be57810535f33114f3
Cr-Commit-Position: refs/heads/master@{#40979}
==========

[commit-bot: I haz the power, 2016-11-17 22:33:24]

Patchset 3 (id:??) landed as
https://crrev.com/e56bd9c332c5b315c18af1be57810535f33114f3
Cr-Commit-Position: refs/heads/master@{#40979}

[commit-bot: I haz the power, 2016-11-17 22:33:29]

Description was changed from

==========
[serializer] print use count of external references.

R=peria@chromium.org, vogelheim@chromium.org
BUG=chromium:617892
NOPRESUBMIT=true

Committed: https://crrev.com/e56bd9c332c5b315c18af1be57810535f33114f3
Cr-Commit-Position: refs/heads/master@{#40979}
==========

to

==========
[serializer] print use count of external references.

R=peria@chromium.org, vogelheim@chromium.org
BUG=chromium:617892
NOPRESUBMIT=true

Committed: https://crrev.com/f0b21ef72cf390f417562f64f15cd3e63a14ae04
Cr-Commit-Position: refs/heads/master@{#40981}
==========

[commit-bot: I haz the power, 2016-11-17 22:33:30]

Patchset 3 (id:??) landed as
https://crrev.com/f0b21ef72cf390f417562f64f15cd3e63a14ae04
Cr-Commit-Position: refs/heads/master@{#40981}