Make the repeat button accessible by keyboard.

Make the repeat button accessible by keyboard.
This change also allows to inject the style for keyboard focus of
files-icon-button to facilitate having consistent styles with other UI
components.

BUG=662829
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/657661ab30800d46991fca1a0070d050e188b921
Cr-Commit-Position: refs/heads/master@{#432124}

[yamaguchi, 2016-11-14 07:32:15]

Description was changed from

==========
Make the repeat button accessible by keyboard.
This change also allows to inject the style for keyboard focus of
files-icon-button to facilitate having consistent styles with other UI
components.

BUG=662829
==========

to

==========
Make the repeat button accessible by keyboard.
This change also allows to inject the style for keyboard focus of
files-icon-button to facilitate having consistent styles with other UI
components.

BUG=662829
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yamaguchi, 2016-11-14 07:33:26]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 07:33:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2016-11-14 07:40:20]

yamaguchi@chromium.org changed reviewers:
+ fukino@chromium.org

[yamaguchi, 2016-11-14 07:40:21]

ptal

[oka, 2016-11-14 07:45:08]

oka@chromium.org changed reviewers:
+ oka@chromium.org

[oka, 2016-11-14 07:45:09]

lgtm

[commit-bot: I haz the power, 2016-11-14 08:05:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 08:05:44]

Dry run: This issue passed the CQ dry run.

[fukino, 2016-11-14 08:09:24]

https://codereview.chromium.org/2495213002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/elements/files_icon_button.html
(right):

https://codereview.chromium.org/2495213002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/elements/files_icon_button.html:39:
@apply(--files-icon-button-keyboard-focus);
Do we need this variable?
<control-panel> specifies the same value.

[yamaguchi, 2016-11-15 02:18:43]

https://codereview.chromium.org/2495213002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/elements/files_icon_button.html
(right):

https://codereview.chromium.org/2495213002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/elements/files_icon_button.html:39:
@apply(--files-icon-button-keyboard-focus);
On 2016/11/14 08:09:24, fukino wrote:
> Do we need this variable?
> <control-panel> specifies the same value.

Line 38 is intended to give default style for this module, so as to preserve
existing styles in other places using this module.
Currently the toolbar in quick view mode of Files app uses this element with the
default style. (Though this might not be what we expect. See crbug/663669.)

[fukino, 2016-11-15 03:32:43]

https://codereview.chromium.org/2495213002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/elements/files_icon_button.html
(right):

https://codereview.chromium.org/2495213002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/elements/files_icon_button.html:39:
@apply(--files-icon-button-keyboard-focus);
On 2016/11/15 02:18:42, yamaguchi wrote:
> On 2016/11/14 08:09:24, fukino wrote:
> > Do we need this variable?
> > <control-panel> specifies the same value.
> 
> Line 38 is intended to give default style for this module, so as to preserve
> existing styles in other places using this module.
> Currently the toolbar in quick view mode of Files app uses this element with
the
> default style. (Though this might not be what we expect. See crbug/663669.)

Per an offline discussion, this variable is for future use.
I think it is somewhat independent from the issue this CL fixes, so let's leave
it from this CL.

[fukino, 2016-11-15 03:59:11]

On 2016/11/15 03:32:43, fukino wrote:
>
https://codereview.chromium.org/2495213002/diff/1/ui/file_manager/file_manage...
> File ui/file_manager/file_manager/foreground/elements/files_icon_button.html
> (right):
> 
>
https://codereview.chromium.org/2495213002/diff/1/ui/file_manager/file_manage...
> ui/file_manager/file_manager/foreground/elements/files_icon_button.html:39:
> @apply(--files-icon-button-keyboard-focus);
> On 2016/11/15 02:18:42, yamaguchi wrote:
> > On 2016/11/14 08:09:24, fukino wrote:
> > > Do we need this variable?
> > > <control-panel> specifies the same value.
> > 
> > Line 38 is intended to give default style for this module, so as to preserve
> > existing styles in other places using this module.
> > Currently the toolbar in quick view mode of Files app uses this element with
> the
> > default style. (Though this might not be what we expect. See crbug/663669.)
> 
> Per an offline discussion, this variable is for future use.
> I think it is somewhat independent from the issue this CL fixes, so let's
leave
> it from this CL.

BTW, LGTM one the variable is removed.

[fukino, 2016-11-15 03:59:14]

On 2016/11/15 03:32:43, fukino wrote:
>
https://codereview.chromium.org/2495213002/diff/1/ui/file_manager/file_manage...
> File ui/file_manager/file_manager/foreground/elements/files_icon_button.html
> (right):
> 
>
https://codereview.chromium.org/2495213002/diff/1/ui/file_manager/file_manage...
> ui/file_manager/file_manager/foreground/elements/files_icon_button.html:39:
> @apply(--files-icon-button-keyboard-focus);
> On 2016/11/15 02:18:42, yamaguchi wrote:
> > On 2016/11/14 08:09:24, fukino wrote:
> > > Do we need this variable?
> > > <control-panel> specifies the same value.
> > 
> > Line 38 is intended to give default style for this module, so as to preserve
> > existing styles in other places using this module.
> > Currently the toolbar in quick view mode of Files app uses this element with
> the
> > default style. (Though this might not be what we expect. See crbug/663669.)
> 
> Per an offline discussion, this variable is for future use.
> I think it is somewhat independent from the issue this CL fixes, so let's
leave
> it from this CL.

BTW, LGTM one the variable is removed.

[yamaguchi, 2016-11-15 04:02:12]

Now the patchset is same as:
https://codereview.chromium.org/2482063002/#ps1

[fukino, 2016-11-15 04:48:32]

On 2016/11/15 04:02:12, yamaguchi wrote:
> Now the patchset is same as:
> https://codereview.chromium.org/2482063002/#ps1

Yes, but you need to upload it as PS3 to commit it.

[yamaguchi, 2016-11-15 05:30:13]

On 2016/11/15 04:48:32, fukino wrote:
> On 2016/11/15 04:02:12, yamaguchi wrote:
> > Now the patchset is same as:
> > https://codereview.chromium.org/2482063002/#ps1
> 
> Yes, but you need to upload it as PS3 to commit it.

Sorry for confusing you. The message above is just to point to the older
discussion as a reference.
Patch Set 2 here is the final version I am going to submit.

[yamaguchi, 2016-11-15 05:31:28]

The CQ bit was checked by yamaguchi@chromium.org

[yamaguchi, 2016-11-15 05:31:29]

The patchset sent to the CQ was uploaded after l-g-t-m from oka@chromium.org
Link to the patchset: https://codereview.chromium.org/2495213002/#ps20001
(title: "Eliminate changes that are not directly related to the issue.")

[commit-bot: I haz the power, 2016-11-15 05:32:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 06:01:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-15 06:08:06]

Description was changed from

==========
Make the repeat button accessible by keyboard.
This change also allows to inject the style for keyboard focus of
files-icon-button to facilitate having consistent styles with other UI
components.

BUG=662829
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Make the repeat button accessible by keyboard.
This change also allows to inject the style for keyboard focus of
files-icon-button to facilitate having consistent styles with other UI
components.

BUG=662829
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/657661ab30800d46991fca1a0070d050e188b921
Cr-Commit-Position: refs/heads/master@{#432124}
==========

[commit-bot: I haz the power, 2016-11-15 06:08:07]

Patchset 2 (id:??) landed as
https://crrev.com/657661ab30800d46991fca1a0070d050e188b921
Cr-Commit-Position: refs/heads/master@{#432124}