Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: content/browser/media/media_canplaytype_browsertest.cc

Issue 2495193004: Refactor VP9 codec string parsing (Closed)
Patch Set: Add a comment to check |level_idc|. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/media/media_browsertest.cc ('k') | media/base/mime_util_internal.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/media_canplaytype_browsertest.cc
diff --git a/content/browser/media/media_canplaytype_browsertest.cc b/content/browser/media/media_canplaytype_browsertest.cc
index 1ae324db1233591d52a685728fb63e389d05478b..4b877708e3a60e4c1e01710d1594b1a17b65f0fc 100644
--- a/content/browser/media/media_canplaytype_browsertest.cc
+++ b/content/browser/media/media_canplaytype_browsertest.cc
@@ -797,9 +797,9 @@ IN_PROC_BROWSER_TEST_F(MediaCanPlayTypeTest, CodecSupportTest_mp4) {
EXPECT_EQ(kHevcSupported,
CanPlay("'video/mp4; codecs=\"hvc1.1.6.L93.B0, mp4a.40.5\"'"));
- // Note: set to kPropProbably when switches::kEnableVp9InMp4 is enabled by
- // default.
- EXPECT_EQ(kNot, CanPlay("'video/mp4; codecs=\"vp09.00.01.08.02.01.01.00\"'"));
+ // switches::kEnableVp9InMp4 is enabled in MediaBrowserTest.
+ EXPECT_EQ(kPropProbably,
+ CanPlay("'video/mp4; codecs=\"vp09.00.01.08.02.01.01.00\"'"));
TestMPEGUnacceptableCombinations("video/mp4");
EXPECT_EQ(kNot, CanPlay("'video/mp4; codecs=\"flac\"'"));
@@ -1645,7 +1645,6 @@ class MediaCanPlayTypeTestMp4Vp9Demuxing
public ::testing::WithParamInterface<bool> {
public:
void SetUpCommandLine(base::CommandLine* command_line) override {
- MediaCanPlayTypeTest::SetUpCommandLine(command_line);
const bool enable_mp4_vp9_demuxing = GetParam();
if (enable_mp4_vp9_demuxing)
command_line->AppendSwitch(switches::kEnableVp9InMp4);
« no previous file with comments | « content/browser/media/media_browsertest.cc ('k') | media/base/mime_util_internal.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698