Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: media/base/video_codecs.h

Issue 2495193004: Refactor VP9 codec string parsing (Closed)
Patch Set: Added a new test in chunk_demuxer_unittest Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/video_codecs.h
diff --git a/media/base/video_codecs.h b/media/base/video_codecs.h
index 6218f7cda3a3a8aa98c3956b67445c7ea4b88646..ed92655956c687628d4598978a525bc5696aeba6 100644
--- a/media/base/video_codecs.h
+++ b/media/base/video_codecs.h
@@ -78,6 +78,20 @@ enum VideoCodecProfile {
std::string MEDIA_EXPORT GetCodecName(VideoCodec codec);
std::string MEDIA_EXPORT GetProfileName(VideoCodecProfile profile);
+// ParseNewStyleVp9CodecID handles parsing of new style vp9 codec IDs per VP
+// Codec ISO Media File Format Binding specification:
ddorwin 2016/11/29 23:48:51 maybe add "proposed".
kqyang 2016/11/30 02:31:17 Done.
+// https://storage.googleapis.com/downloads.webmproject.org/docs/vp9/vp-codec-iso-media-file-format-binding-20160516-draft.pdf
+// ParseLegacyVp9CodecID handles parsing of legacy VP9 codec strings defined
+// for WebM.
+// TODO(kqyang): Consolidate the two functions once we addressed
ddorwin 2016/11/29 23:48:51 nit: address
kqyang 2016/11/30 02:31:17 Done.
+// http://crbug.com/667834
+MEDIA_EXPORT bool ParseNewStyleVp9CodecID(const std::string& codec_id,
+ VideoCodecProfile* profile,
+ uint8_t* level_idc);
+MEDIA_EXPORT bool ParseLegacyVp9CodecID(const std::string& codec_id,
+ VideoCodecProfile* profile,
+ uint8_t* level_idc);
+
// Handle parsing AVC/H.264 codec ids as outlined in RFC 6381 and ISO-14496-10.
MEDIA_EXPORT bool ParseAVCCodecId(const std::string& codec_id,
VideoCodecProfile* profile,

Powered by Google App Engine
This is Rietveld 408576698