chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc - Issue 2495193003: Convert spellcheck to a buildflag header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc

Issue 2495193003: Convert spellcheck to a buildflag header. (Closed)

Patch Set: Comment Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/configuration_policy_handler_list_factory.cc ('k') | chrome/browser/renderer_context_menu/render_view_context_menu.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc

diff --git a/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc b/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc

index 2dcb1d243eeac1b469a77a4baf132cea6fde4add..0c6091e65eb1852aeb6ebad0d187212376726140 100644

--- a/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc

+++ b/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc

@@ -70,6 +70,7 @@

#include "chrome/browser/undo/bookmark_undo_service_factory.h"

#include "chrome/browser/web_data_service_factory.h"

#include "chrome/common/features.h"

+#include "components/spellcheck/spellcheck_build_features.h"

#include "extensions/features/features.h"

#include "printing/features/features.h"

@@ -133,7 +134,7 @@

#include "chrome/browser/profile_resetter/triggered_profile_resetter_factory.h"

#endif

-#if defined(ENABLE_SPELLCHECK)

+#if BUILDFLAG(ENABLE_SPELLCHECK)

#include "chrome/browser/spellchecker/spellcheck_factory.h"

#endif

@@ -326,7 +327,7 @@ EnsureBrowserContextKeyedServiceFactoriesBuilt() {

if (SiteEngagementService::IsEnabled())

SiteEngagementServiceFactory::GetInstance();

-#if defined(ENABLE_SPELLCHECK)

+#if BUILDFLAG(ENABLE_SPELLCHECK)

SpellcheckServiceFactory::GetInstance();

#endif

suggestions::SuggestionsServiceFactory::GetInstance();