chrome/browser/extensions/browser_context_keyed_service_factories.cc - Issue 2495193003: Convert spellcheck to a buildflag header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/browser_context_keyed_service_factories.cc

Issue 2495193003: Convert spellcheck to a buildflag header. (Closed)

Patch Set: Comment Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/policy/configuration_policy_handler_list_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/browser_context_keyed_service_factories.cc

diff --git a/chrome/browser/extensions/browser_context_keyed_service_factories.cc b/chrome/browser/extensions/browser_context_keyed_service_factories.cc

index d050ab9127102062c29e630052256361df08c354..50cd87bb48ad7cb3d4cfa5fa86d2e8cf97d64e4a 100644

--- a/chrome/browser/extensions/browser_context_keyed_service_factories.cc

+++ b/chrome/browser/extensions/browser_context_keyed_service_factories.cc

@@ -53,6 +53,7 @@

#include "chrome/browser/speech/extension_api/tts_extension_api.h"

#include "chrome/browser/ui/toolbar/toolbar_actions_model_factory.h"

#include "chrome/common/features.h"

+#include "components/spellcheck/spellcheck_build_features.h"

#include "extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_api.h"

#if defined(OS_CHROMEOS)

@@ -70,7 +71,7 @@

#include "chrome/browser/extensions/api/mdns/mdns_api.h"

#endif

-#if defined(ENABLE_SPELLCHECK)

+#if BUILDFLAG(ENABLE_SPELLCHECK)

#include "chrome/browser/extensions/api/spellcheck/spellcheck_api.h"

#endif

@@ -135,7 +136,7 @@ void EnsureBrowserContextKeyedServiceFactoriesBuilt() {

extensions::SettingsPrivateEventRouterFactory::GetInstance();

extensions::SettingsOverridesAPI::GetFactoryInstance();

extensions::SignedInDevicesManager::GetFactoryInstance();

-#if defined(ENABLE_SPELLCHECK)

+#if BUILDFLAG(ENABLE_SPELLCHECK)

extensions::SpellcheckAPI::GetFactoryInstance();

#endif

extensions::StreamsPrivateAPI::GetFactoryInstance();