Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2495193003: Convert spellcheck to a buildflag header. (Closed)
Patch Set: Comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/android/chrome_jni_registrar.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 #include "components/ntp_tiles/switches.h" 49 #include "components/ntp_tiles/switches.h"
50 #include "components/offline_pages/offline_page_feature.h" 50 #include "components/offline_pages/offline_page_feature.h"
51 #include "components/omnibox/browser/omnibox_switches.h" 51 #include "components/omnibox/browser/omnibox_switches.h"
52 #include "components/password_manager/core/common/password_manager_features.h" 52 #include "components/password_manager/core/common/password_manager_features.h"
53 #include "components/proximity_auth/switches.h" 53 #include "components/proximity_auth/switches.h"
54 #include "components/search/search_switches.h" 54 #include "components/search/search_switches.h"
55 #include "components/security_state/switches.h" 55 #include "components/security_state/switches.h"
56 #include "components/signin/core/common/signin_switches.h" 56 #include "components/signin/core/common/signin_switches.h"
57 #include "components/spellcheck/common/spellcheck_features.h" 57 #include "components/spellcheck/common/spellcheck_features.h"
58 #include "components/spellcheck/common/spellcheck_switches.h" 58 #include "components/spellcheck/common/spellcheck_switches.h"
59 #include "components/spellcheck/spellcheck_build_features.h"
59 #include "components/ssl_config/ssl_config_switches.h" 60 #include "components/ssl_config/ssl_config_switches.h"
60 #include "components/strings/grit/components_strings.h" 61 #include "components/strings/grit/components_strings.h"
61 #include "components/sync/driver/sync_driver_switches.h" 62 #include "components/sync/driver/sync_driver_switches.h"
62 #include "components/tracing/common/tracing_switches.h" 63 #include "components/tracing/common/tracing_switches.h"
63 #include "components/translate/core/browser/translate_manager.h" 64 #include "components/translate/core/browser/translate_manager.h"
64 #include "components/translate/core/browser/translate_prefs.h" 65 #include "components/translate/core/browser/translate_prefs.h"
65 #include "components/version_info/version_info.h" 66 #include "components/version_info/version_info.h"
66 #include "content/public/browser/user_metrics.h" 67 #include "content/public/browser/user_metrics.h"
67 #include "content/public/common/content_features.h" 68 #include "content/public/common/content_features.h"
68 #include "content/public/common/content_switches.h" 69 #include "content/public/common/content_switches.h"
(...skipping 768 matching lines...) Expand 10 before | Expand all | Expand 10 after
837 IDS_FLAGS_BLE_ADVERTISING_IN_EXTENSIONS_DESCRIPTION, kOsCrOS, 838 IDS_FLAGS_BLE_ADVERTISING_IN_EXTENSIONS_DESCRIPTION, kOsCrOS,
838 SINGLE_VALUE_TYPE(extensions::switches::kEnableBLEAdvertising)}, 839 SINGLE_VALUE_TYPE(extensions::switches::kEnableBLEAdvertising)},
839 #endif // ENABLE_EXTENSIONS 840 #endif // ENABLE_EXTENSIONS
840 {"enable-devtools-experiments", IDS_FLAGS_DEVTOOLS_EXPERIMENTS_NAME, 841 {"enable-devtools-experiments", IDS_FLAGS_DEVTOOLS_EXPERIMENTS_NAME,
841 IDS_FLAGS_DEVTOOLS_EXPERIMENTS_DESCRIPTION, kOsDesktop, 842 IDS_FLAGS_DEVTOOLS_EXPERIMENTS_DESCRIPTION, kOsDesktop,
842 SINGLE_VALUE_TYPE(switches::kEnableDevToolsExperiments)}, 843 SINGLE_VALUE_TYPE(switches::kEnableDevToolsExperiments)},
843 {"silent-debugger-extension-api", 844 {"silent-debugger-extension-api",
844 IDS_FLAGS_SILENT_DEBUGGER_EXTENSION_API_NAME, 845 IDS_FLAGS_SILENT_DEBUGGER_EXTENSION_API_NAME,
845 IDS_FLAGS_SILENT_DEBUGGER_EXTENSION_API_DESCRIPTION, kOsDesktop, 846 IDS_FLAGS_SILENT_DEBUGGER_EXTENSION_API_DESCRIPTION, kOsDesktop,
846 SINGLE_VALUE_TYPE(switches::kSilentDebuggerExtensionAPI)}, 847 SINGLE_VALUE_TYPE(switches::kSilentDebuggerExtensionAPI)},
847 #if defined(ENABLE_SPELLCHECK) && defined(OS_ANDROID) 848 #if BUILDFLAG(ENABLE_SPELLCHECK) && defined(OS_ANDROID)
848 {"enable-android-spellchecker", IDS_OPTIONS_ENABLE_SPELLCHECK, 849 {"enable-android-spellchecker", IDS_OPTIONS_ENABLE_SPELLCHECK,
849 IDS_OPTIONS_ENABLE_ANDROID_SPELLCHECKER_DESCRIPTION, kOsAndroid, 850 IDS_OPTIONS_ENABLE_ANDROID_SPELLCHECKER_DESCRIPTION, kOsAndroid,
850 FEATURE_VALUE_TYPE(spellcheck::kAndroidSpellChecker)}, 851 FEATURE_VALUE_TYPE(spellcheck::kAndroidSpellChecker)},
851 #endif // ENABLE_SPELLCHECK && OS_ANDROID 852 #endif // ENABLE_SPELLCHECK && OS_ANDROID
852 {"enable-scroll-prediction", IDS_FLAGS_SCROLL_PREDICTION_NAME, 853 {"enable-scroll-prediction", IDS_FLAGS_SCROLL_PREDICTION_NAME,
853 IDS_FLAGS_SCROLL_PREDICTION_DESCRIPTION, kOsDesktop, 854 IDS_FLAGS_SCROLL_PREDICTION_DESCRIPTION, kOsDesktop,
854 SINGLE_VALUE_TYPE(switches::kEnableScrollPrediction)}, 855 SINGLE_VALUE_TYPE(switches::kEnableScrollPrediction)},
855 {"top-chrome-md", IDS_FLAGS_TOP_CHROME_MD, 856 {"top-chrome-md", IDS_FLAGS_TOP_CHROME_MD,
856 IDS_FLAGS_TOP_CHROME_MD_DESCRIPTION, kOsDesktop, 857 IDS_FLAGS_TOP_CHROME_MD_DESCRIPTION, kOsDesktop,
857 MULTI_VALUE_TYPE(kTopChromeMaterialDesignChoices)}, 858 MULTI_VALUE_TYPE(kTopChromeMaterialDesignChoices)},
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
1191 SINGLE_VALUE_TYPE(switches::kEnableCloudPrintXps)}, 1192 SINGLE_VALUE_TYPE(switches::kEnableCloudPrintXps)},
1192 #endif // OS_WIN 1193 #endif // OS_WIN
1193 #if defined(TOOLKIT_VIEWS) 1194 #if defined(TOOLKIT_VIEWS)
1194 {"disable-hide-inactive-stacked-tab-close-buttons", 1195 {"disable-hide-inactive-stacked-tab-close-buttons",
1195 IDS_FLAGS_HIDE_INACTIVE_STACKED_TAB_CLOSE_BUTTONS_NAME, 1196 IDS_FLAGS_HIDE_INACTIVE_STACKED_TAB_CLOSE_BUTTONS_NAME,
1196 IDS_FLAGS_HIDE_INACTIVE_STACKED_TAB_CLOSE_BUTTONS_DESCRIPTION, 1197 IDS_FLAGS_HIDE_INACTIVE_STACKED_TAB_CLOSE_BUTTONS_DESCRIPTION,
1197 kOsCrOS | kOsWin | kOsLinux, 1198 kOsCrOS | kOsWin | kOsLinux,
1198 SINGLE_DISABLE_VALUE_TYPE( 1199 SINGLE_DISABLE_VALUE_TYPE(
1199 switches::kDisableHideInactiveStackedTabCloseButtons)}, 1200 switches::kDisableHideInactiveStackedTabCloseButtons)},
1200 #endif // TOOLKIT_VIEWS 1201 #endif // TOOLKIT_VIEWS
1201 #if defined(ENABLE_SPELLCHECK) 1202 #if BUILDFLAG(ENABLE_SPELLCHECK)
1202 {"enable-spelling-feedback-field-trial", 1203 {"enable-spelling-feedback-field-trial",
1203 IDS_FLAGS_SPELLING_FEEDBACK_FIELD_TRIAL_NAME, 1204 IDS_FLAGS_SPELLING_FEEDBACK_FIELD_TRIAL_NAME,
1204 IDS_FLAGS_SPELLING_FEEDBACK_FIELD_TRIAL_DESCRIPTION, kOsAll, 1205 IDS_FLAGS_SPELLING_FEEDBACK_FIELD_TRIAL_DESCRIPTION, kOsAll,
1205 SINGLE_VALUE_TYPE( 1206 SINGLE_VALUE_TYPE(
1206 spellcheck::switches::kEnableSpellingFeedbackFieldTrial)}, 1207 spellcheck::switches::kEnableSpellingFeedbackFieldTrial)},
1207 #endif // ENABLE_SPELLCHECK 1208 #endif // ENABLE_SPELLCHECK
1208 {"enable-webgl-draft-extensions", IDS_FLAGS_WEBGL_DRAFT_EXTENSIONS_NAME, 1209 {"enable-webgl-draft-extensions", IDS_FLAGS_WEBGL_DRAFT_EXTENSIONS_NAME,
1209 IDS_FLAGS_WEBGL_DRAFT_EXTENSIONS_DESCRIPTION, kOsAll, 1210 IDS_FLAGS_WEBGL_DRAFT_EXTENSIONS_DESCRIPTION, kOsAll,
1210 SINGLE_VALUE_TYPE(switches::kEnableWebGLDraftExtensions)}, 1211 SINGLE_VALUE_TYPE(switches::kEnableWebGLDraftExtensions)},
1211 {"enable-new-profile-management", IDS_FLAGS_NEW_PROFILE_MANAGEMENT_NAME, 1212 {"enable-new-profile-management", IDS_FLAGS_NEW_PROFILE_MANAGEMENT_NAME,
(...skipping 1107 matching lines...) Expand 10 before | Expand all | Expand 10 after
2319 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2320 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2320 2321
2321 const FeatureEntry* GetFeatureEntries(size_t* count) { 2322 const FeatureEntry* GetFeatureEntries(size_t* count) {
2322 *count = arraysize(kFeatureEntries); 2323 *count = arraysize(kFeatureEntries);
2323 return kFeatureEntries; 2324 return kFeatureEntries;
2324 } 2325 }
2325 2326
2326 } // namespace testing 2327 } // namespace testing
2327 2328
2328 } // namespace about_flags 2329 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/android/chrome_jni_registrar.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698