Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 249513002: [Android] Remove global --gc-sections ldflag from Debug targets. (Closed)

Created:
6 years, 8 months ago by Primiano Tucci (use gerrit)
Modified:
6 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, bulach, Torne, rmcilroy
Visibility:
Public.

Description

[Android] Remove global --gc-sections ldflag from Debug targets. After some major cleanup, all but very few Android targets (i.e. chrome_shell_apk and chrome_unittests_apk) have stopped depending on the linker GC section to build succesfully. This change removes the global --gc-section arg from all Debug targets in order to prevent future regressions. BUG=159847 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265678

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Primiano Tucci (use gerrit)
Nico: TBR-ing this since it is just a one-line cut away from crrev.com/228003006. I did ...
6 years, 8 months ago (2014-04-23 15:30:19 UTC) #1
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 8 months ago (2014-04-23 15:30:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/249513002/1
6 years, 8 months ago (2014-04-23 15:30:49 UTC) #3
Nico
lgtm
6 years, 8 months ago (2014-04-23 16:28:47 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 17:39:40 UTC) #5
Message was sent while issue was closed.
Change committed as 265678

Powered by Google App Engine
This is Rietveld 408576698