Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Side by Side Diff: cc/trees/scroll_node.cc

Issue 2495123002: Make all scrollable layers visible to hit testing. (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/trees/scroll_node.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/trace_event/trace_event_argument.h" 5 #include "base/trace_event/trace_event_argument.h"
6 #include "cc/animation/element_id.h" 6 #include "cc/animation/element_id.h"
7 #include "cc/base/math_util.h" 7 #include "cc/base/math_util.h"
8 #include "cc/input/main_thread_scrolling_reason.h" 8 #include "cc/input/main_thread_scrolling_reason.h"
9 #include "cc/proto/gfx_conversions.h" 9 #include "cc/proto/gfx_conversions.h"
10 #include "cc/trees/scroll_node.h" 10 #include "cc/trees/scroll_node.h"
11 11
12 namespace cc { 12 namespace cc {
13 13
14 ScrollNode::ScrollNode() 14 ScrollNode::ScrollNode()
15 : id(-1), 15 : id(-1),
16 parent_id(-1), 16 parent_id(-1),
17 owner_id(-1), 17 owner_id(-1),
18 scrollable(false), 18 scrollable(false),
19 main_thread_scrolling_reasons( 19 main_thread_scrolling_reasons(
20 MainThreadScrollingReason::kNotScrollingOnMain), 20 MainThreadScrollingReason::kNotScrollingOnMain),
21 contains_non_fast_scrollable_region(false), 21 contains_non_fast_scrollable_region(false),
22 max_scroll_offset_affected_by_page_scale(false), 22 max_scroll_offset_affected_by_page_scale(false),
23 is_inner_viewport_scroll_layer(false), 23 is_inner_viewport_scroll_layer(false),
24 is_outer_viewport_scroll_layer(false), 24 is_outer_viewport_scroll_layer(false),
25 should_flatten(false), 25 should_flatten(false),
26 user_scrollable_horizontal(false), 26 user_scrollable_horizontal(false),
27 user_scrollable_vertical(false), 27 user_scrollable_vertical(false),
28 transform_id(0), 28 transform_id(0) {}
29 num_drawn_descendants(0) {}
30 29
31 ScrollNode::ScrollNode(const ScrollNode& other) = default; 30 ScrollNode::ScrollNode(const ScrollNode& other) = default;
32 31
33 bool ScrollNode::operator==(const ScrollNode& other) const { 32 bool ScrollNode::operator==(const ScrollNode& other) const {
34 return id == other.id && parent_id == other.parent_id && 33 return id == other.id && parent_id == other.parent_id &&
35 owner_id == other.owner_id && scrollable == other.scrollable && 34 owner_id == other.owner_id && scrollable == other.scrollable &&
36 main_thread_scrolling_reasons == other.main_thread_scrolling_reasons && 35 main_thread_scrolling_reasons == other.main_thread_scrolling_reasons &&
37 contains_non_fast_scrollable_region == 36 contains_non_fast_scrollable_region ==
38 other.contains_non_fast_scrollable_region && 37 other.contains_non_fast_scrollable_region &&
39 scroll_clip_layer_bounds == other.scroll_clip_layer_bounds && 38 scroll_clip_layer_bounds == other.scroll_clip_layer_bounds &&
(...skipping 23 matching lines...) Expand all
63 offset_to_transform_parent, value); 62 offset_to_transform_parent, value);
64 value->SetBoolean("should_flatten", should_flatten); 63 value->SetBoolean("should_flatten", should_flatten);
65 value->SetBoolean("user_scrollable_horizontal", user_scrollable_horizontal); 64 value->SetBoolean("user_scrollable_horizontal", user_scrollable_horizontal);
66 value->SetBoolean("user_scrollable_vertical", user_scrollable_vertical); 65 value->SetBoolean("user_scrollable_vertical", user_scrollable_vertical);
67 66
68 element_id.AddToTracedValue(value); 67 element_id.AddToTracedValue(value);
69 value->SetInteger("transform_id", transform_id); 68 value->SetInteger("transform_id", transform_id);
70 } 69 }
71 70
72 } // namespace cc 71 } // namespace cc
OLDNEW
« no previous file with comments | « cc/trees/scroll_node.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698