src/isolate.cc - Issue 249503002: Trigger debug event on not yet caught exception in promises.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.cc

Issue 249503002: Trigger debug event on not yet caught exception in promises. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: always use original exception Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/isolate.cc

diff --git a/src/isolate.cc b/src/isolate.cc

index 9a5bc5ad43b16e9bc7fabb2fe07cf06bee7b858c..4cdcef338456c601e88fd9ff802cfd33c5fe9b9f 100644

--- a/src/isolate.cc

+++ b/src/isolate.cc

@@ -1055,7 +1055,8 @@ void Isolate::DoThrow(Object* exception, MessageLocation* location) {

#ifdef ENABLE_DEBUGGER_SUPPORT

// Notify debugger of exception.

if (catchable_by_javascript) {

- debugger_->OnException(exception_handle, report_exception);

+ debugger_->OnException(

+ exception_handle, report_exception, factory()->undefined_value());

}

#endif

« src/debug-debugger.js ('K') | « src/execution.cc ('k') | src/promise.js » ('j') | no next file with comments »