Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: src/runtime.cc

Issue 249503002: Trigger debug event on not yet caught exception in promises. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5631 matching lines...) Expand 10 before | Expand all | Expand 10 after
5642 // When leaving the callback, step out has been activated, but not performed 5642 // When leaving the callback, step out has been activated, but not performed
5643 // if we do not leave the builtin. To be able to step into the callback 5643 // if we do not leave the builtin. To be able to step into the callback
5644 // again, we need to clear the step out at this point. 5644 // again, we need to clear the step out at this point.
5645 debug->ClearStepOut(); 5645 debug->ClearStepOut();
5646 debug->FloodWithOneShot(callback); 5646 debug->FloodWithOneShot(callback);
5647 #endif // ENABLE_DEBUGGER_SUPPORT 5647 #endif // ENABLE_DEBUGGER_SUPPORT
5648 return isolate->heap()->undefined_value(); 5648 return isolate->heap()->undefined_value();
5649 } 5649 }
5650 5650
5651 5651
5652 // Notify the debugger if an expcetion in a promise is not caught (yet).
5653 RUNTIME_FUNCTION(Runtime_DebugPendingExceptionInPromise) {
5654 SealHandleScope shs(isolate);
5655 #ifdef ENABLE_DEBUGGER_SUPPORT
5656 ASSERT(args.length() == 2);
5657 HandleScope scope(isolate);
5658 CONVERT_ARG_HANDLE_CHECKED(Object, exception, 0);
5659 CONVERT_ARG_HANDLE_CHECKED(Object, promise, 1);
5660 isolate->debugger()->OnException(exception, true, promise);
5661 #endif // ENABLE_DEBUGGER_SUPPORT
5662 return isolate->heap()->undefined_value();
5663 }
5664
5665
5652 // Set a local property, even if it is READ_ONLY. If the property does not 5666 // Set a local property, even if it is READ_ONLY. If the property does not
5653 // exist, it will be added with attributes NONE. 5667 // exist, it will be added with attributes NONE.
5654 RUNTIME_FUNCTION(Runtime_IgnoreAttributesAndSetProperty) { 5668 RUNTIME_FUNCTION(Runtime_IgnoreAttributesAndSetProperty) {
5655 HandleScope scope(isolate); 5669 HandleScope scope(isolate);
5656 RUNTIME_ASSERT(args.length() == 3 || args.length() == 4); 5670 RUNTIME_ASSERT(args.length() == 3 || args.length() == 4);
5657 CONVERT_ARG_HANDLE_CHECKED(JSObject, object, 0); 5671 CONVERT_ARG_HANDLE_CHECKED(JSObject, object, 0);
5658 CONVERT_ARG_HANDLE_CHECKED(Name, name, 1); 5672 CONVERT_ARG_HANDLE_CHECKED(Name, name, 1);
5659 CONVERT_ARG_HANDLE_CHECKED(Object, value, 2); 5673 CONVERT_ARG_HANDLE_CHECKED(Object, value, 2);
5660 // Compute attributes. 5674 // Compute attributes.
5661 PropertyAttributes attributes = NONE; 5675 PropertyAttributes attributes = NONE;
(...skipping 9455 matching lines...) Expand 10 before | Expand all | Expand 10 after
15117 } 15131 }
15118 return NULL; 15132 return NULL;
15119 } 15133 }
15120 15134
15121 15135
15122 const Runtime::Function* Runtime::FunctionForId(Runtime::FunctionId id) { 15136 const Runtime::Function* Runtime::FunctionForId(Runtime::FunctionId id) {
15123 return &(kIntrinsicFunctions[static_cast<int>(id)]); 15137 return &(kIntrinsicFunctions[static_cast<int>(id)]);
15124 } 15138 }
15125 15139
15126 } } // namespace v8::internal 15140 } } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698