Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Side by Side Diff: src/isolate.cc

Issue 249503002: Trigger debug event on not yet caught exception in promises. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: always use original exception Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1037 matching lines...) Expand 10 before | Expand all | Expand 10 after
1048 bool try_catch_needs_message = 1048 bool try_catch_needs_message =
1049 can_be_caught_externally && try_catch_handler()->capture_message_ && 1049 can_be_caught_externally && try_catch_handler()->capture_message_ &&
1050 !thread_local_top()->rethrowing_message_; 1050 !thread_local_top()->rethrowing_message_;
1051 bool bootstrapping = bootstrapper()->IsActive(); 1051 bool bootstrapping = bootstrapper()->IsActive();
1052 1052
1053 thread_local_top()->rethrowing_message_ = false; 1053 thread_local_top()->rethrowing_message_ = false;
1054 1054
1055 #ifdef ENABLE_DEBUGGER_SUPPORT 1055 #ifdef ENABLE_DEBUGGER_SUPPORT
1056 // Notify debugger of exception. 1056 // Notify debugger of exception.
1057 if (catchable_by_javascript) { 1057 if (catchable_by_javascript) {
1058 debugger_->OnException(exception_handle, report_exception); 1058 debugger_->OnException(
1059 exception_handle, report_exception, factory()->undefined_value());
1059 } 1060 }
1060 #endif 1061 #endif
1061 1062
1062 // Generate the message if required. 1063 // Generate the message if required.
1063 if (report_exception || try_catch_needs_message) { 1064 if (report_exception || try_catch_needs_message) {
1064 MessageLocation potential_computed_location; 1065 MessageLocation potential_computed_location;
1065 if (location == NULL) { 1066 if (location == NULL) {
1066 // If no location was specified we use a computed one instead. 1067 // If no location was specified we use a computed one instead.
1067 ComputeLocation(&potential_computed_location); 1068 ComputeLocation(&potential_computed_location);
1068 location = &potential_computed_location; 1069 location = &potential_computed_location;
(...skipping 1181 matching lines...) Expand 10 before | Expand all | Expand 10 after
2250 Handle<JSObject> obj = factory()->NewJSObjectFromMap(map); 2251 Handle<JSObject> obj = factory()->NewJSObjectFromMap(map);
2251 JSObject::NormalizeProperties(obj, KEEP_INOBJECT_PROPERTIES, 8); 2252 JSObject::NormalizeProperties(obj, KEEP_INOBJECT_PROPERTIES, 8);
2252 JSObject::SetProperty(registry, name, obj, NONE, STRICT).Assert(); 2253 JSObject::SetProperty(registry, name, obj, NONE, STRICT).Assert();
2253 } 2254 }
2254 } 2255 }
2255 return Handle<JSObject>::cast(factory()->symbol_registry()); 2256 return Handle<JSObject>::cast(factory()->symbol_registry());
2256 } 2257 }
2257 2258
2258 2259
2259 } } // namespace v8::internal 2260 } } // namespace v8::internal
OLDNEW
« src/debug-debugger.js ('K') | « src/execution.cc ('k') | src/promise.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698