Add kernel/closed_world_test

Add kernel/closed_world_test

R=het@google.com

Committed: https://github.com/dart-lang/sdk/commit/6689fb80cd376ee63d526a132d4ae35da344182e

[Johnni Winther, 2016-11-11 14:51:43]

johnniwinther@google.com changed reviewers:
+ het@google.com

[Harry Terkelsen, 2016-11-11 18:42:00]

lgtm

but please add more context

https://codereview.chromium.org/2495013002/diff/1/tests/compiler/dart2js/kern...
File tests/compiler/dart2js/kernel/closed_world_test.dart (right):

https://codereview.chromium.org/2495013002/diff/1/tests/compiler/dart2js/kern...
tests/compiler/dart2js/kernel/closed_world_test.dart:41: main(List<String> args)
{
Can you write a comment explaining what exactly this test is testing? It's hard
to see what's going on. It looks like you are running resolution twice with the
same compiler and checking that the closed world built using "build" from
"impact_test" is the same as the one using the normal resolution enqueuer?

https://codereview.chromium.org/2495013002/diff/1/tests/compiler/dart2js/kern...
tests/compiler/dart2js/kernel/closed_world_test.dart:79: // made to reset a
field in [TypeVariableHandler] the prevents it from
the prevents -> that prevents

[Johnni Winther, 2016-11-14 10:05:26]

https://codereview.chromium.org/2495013002/diff/1/tests/compiler/dart2js/kern...
File tests/compiler/dart2js/kernel/closed_world_test.dart (right):

https://codereview.chromium.org/2495013002/diff/1/tests/compiler/dart2js/kern...
tests/compiler/dart2js/kernel/closed_world_test.dart:41: main(List<String> args)
{
On 2016/11/11 18:41:59, Harry Terkelsen wrote:
> Can you write a comment explaining what exactly this test is testing? It's
hard
> to see what's going on. It looks like you are running resolution twice with
the
> same compiler and checking that the closed world built using "build" from
> "impact_test" is the same as the one using the normal resolution enqueuer?

That is exactly what I'm doing :) Added a library and in-code comment.

https://codereview.chromium.org/2495013002/diff/1/tests/compiler/dart2js/kern...
tests/compiler/dart2js/kernel/closed_world_test.dart:79: // made to reset a
field in [TypeVariableHandler] the prevents it from
On 2016/11/11 18:41:59, Harry Terkelsen wrote:
> the prevents -> that prevents

Done.

[Johnni Winther, 2016-11-14 10:11:49]

Description was changed from

==========
Add kernel/closed_world_test
==========

to

==========
Add kernel/closed_world_test

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6689fb80cd376ee63d526a132d4ae35da344182e
==========

[Johnni Winther, 2016-11-14 10:11:50]

Committed patchset #2 (id:20001) manually as
6689fb80cd376ee63d526a132d4ae35da344182e (presubmit successful).