Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2495003006: Fix unique ptrs in fpdfppo.cpp (Closed)

Created:
4 years, 1 month ago by Tom Sepez
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix unique ptrs in fpdfppo.cpp There's a path out that deletes a pointer whose ownership was passed off earlier. This will get simpler once more APIs take unique_ptr. BUG=664284 Committed: https://pdfium.googlesource.com/pdfium/+/6e1d6032b7990cdf580c99ff491a1b761ee39ca6

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1189 lines, -4 lines) Patch
M fpdfsdk/fpdfppo.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdfppo_embeddertest.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
M fpdfsdk/fpdfsave_embeddertest.cpp View 2 chunks +19 lines, -1 line 0 comments Download
A testing/resources/bug_664284.in View 1 chunk +75 lines, -0 lines 0 comments Download
A testing/resources/bug_664284.pdf View 1 1 chunk +1078 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Tom Sepez
Lei, ready for review. This is the actual bug I set out to fix this ...
4 years, 1 month ago (2016-11-12 00:54:23 UTC) #2
Lei Zhang
lgtm
4 years, 1 month ago (2016-11-12 01:04:48 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2488403004 Patch 60001). Please resolve the dependency and ...
4 years, 1 month ago (2016-11-12 01:21:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495003006/20001
4 years, 1 month ago (2016-11-12 01:25:42 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-12 01:55:45 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/6e1d6032b7990cdf580c99ff491a1b761ee3...

Powered by Google App Engine
This is Rietveld 408576698