Loading: Factor out ResourceFetcherMockFetchContext

Loading: Factor out ResourceFetcherMockFetchContext

Factor out ResourceFetcherMockFetchContext as MockFetchContext
so that multiple unit tests can use it for mocking FetchContext
on unit tests.

I'm planning to split ResourceFetcherTest.cpp into multiple files
so that I can remove undesirable dependencies from the tests to
Resource and ResourceClient sub-classes. Once the tests are split
into multiple files, they all will use this single header file
to have a mocked FetchContext.

BUG=655920
Committed: https://crrev.com/162f29c10a4d1e9d037ed42c34eb9460ae20a5bb
Cr-Commit-Position: refs/heads/master@{#431849}

[Takashi Toyoshima, 2016-11-11 11:30:29]

Description was changed from

==========
Loading: Factor out ResourceFetcherMockFetchContext

Factor out ResourceFetcherMockFetchContext as MockFetchContext
so that multiple unit tests can use it for mocking FetchContext
on unit tests.

I'm planning to split ResourceFetcherTest.cpp into multiple files
so that I can remove undesirable dependencies from the tests to
Resource and ResourceClient sub-classes. Once the tests are split
into multiple files, they all will use this single header file
to have a mocked FetchContext.

BUG=655920
==========

to

==========
Loading: Factor out ResourceFetcherMockFetchContext

Factor out ResourceFetcherMockFetchContext as MockFetchContext
so that multiple unit tests can use it for mocking FetchContext
on unit tests.

I'm planning to split ResourceFetcherTest.cpp into multiple files
so that I can remove undesirable dependencies from the tests to
Resource and ResourceClient sub-classes. Once the tests are split
into multiple files, they all will use this single header file
to have a mocked FetchContext.

BUG=655920
==========

[Takashi Toyoshima, 2016-11-11 11:30:29]

toyoshim@chromium.org changed reviewers:
+ hiroshige@chromium.org, yhirano@chromium.org

[Takashi Toyoshima, 2016-11-11 11:30:52]

ptal

[Takashi Toyoshima, 2016-11-11 11:30:58]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 11:31:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 13:50:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 13:50:23]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-11-14 04:49:13]

lgtm

https://codereview.chromium.org/2495003002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/MockFetchContext.h (right):

https://codereview.chromium.org/2495003002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/MockFetchContext.h:14: 
+<memory>

https://codereview.chromium.org/2495003002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/MockFetchContext.h:34: virtual
~MockFetchContext() {}
+override
-virtual

[hiroshige, 2016-11-14 05:21:25]

lgtm

[Takashi Toyoshima, 2016-11-14 05:34:32]

https://codereview.chromium.org/2495003002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/MockFetchContext.h (right):

https://codereview.chromium.org/2495003002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/MockFetchContext.h:14: 
On 2016/11/14 04:49:13, yhirano wrote:
> +<memory>

Done.

https://codereview.chromium.org/2495003002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/MockFetchContext.h:34: virtual
~MockFetchContext() {}
On 2016/11/14 04:49:13, yhirano wrote:
> +override
> -virtual

Done.

[Takashi Toyoshima, 2016-11-14 05:34:37]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2016-11-14 05:34:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
hiroshige@chromium.org, yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2495003002/#ps40001
(title: "review #8")

[commit-bot: I haz the power, 2016-11-14 05:34:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 05:40:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 05:40:45]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Takashi Toyoshima, 2016-11-14 05:53:29]

toyoshim@chromium.org changed reviewers:
+ tkent@chromium.org

[Takashi Toyoshima, 2016-11-14 05:53:42]

+tkent for core/BUILD.gn

[tkent, 2016-11-14 06:04:11]

lgtm

https://codereview.chromium.org/2495003002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/MockFetchContext.h (right):

https://codereview.chromium.org/2495003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/MockFetchContext.h:29:
ShouldLoadNewResource,
Please use kCamelCase style for new enum.

kShouldLoadNewResource,
kShouldNotLoadNewResource,

[Takashi Toyoshima, 2016-11-14 06:41:15]

https://codereview.chromium.org/2495003002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/MockFetchContext.h (right):

https://codereview.chromium.org/2495003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/MockFetchContext.h:29:
ShouldLoadNewResource,
Oh, thank you for this. I didn't notice this recent policy in the style
guideline.

[Takashi Toyoshima, 2016-11-14 06:42:08]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2016-11-14 06:42:09]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
hiroshige@chromium.org, yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2495003002/#ps60001
(title: "enum k prefix")

[commit-bot: I haz the power, 2016-11-14 06:42:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 10:28:33]

Description was changed from

==========
Loading: Factor out ResourceFetcherMockFetchContext

Factor out ResourceFetcherMockFetchContext as MockFetchContext
so that multiple unit tests can use it for mocking FetchContext
on unit tests.

I'm planning to split ResourceFetcherTest.cpp into multiple files
so that I can remove undesirable dependencies from the tests to
Resource and ResourceClient sub-classes. Once the tests are split
into multiple files, they all will use this single header file
to have a mocked FetchContext.

BUG=655920
==========

to

==========
Loading: Factor out ResourceFetcherMockFetchContext

Factor out ResourceFetcherMockFetchContext as MockFetchContext
so that multiple unit tests can use it for mocking FetchContext
on unit tests.

I'm planning to split ResourceFetcherTest.cpp into multiple files
so that I can remove undesirable dependencies from the tests to
Resource and ResourceClient sub-classes. Once the tests are split
into multiple files, they all will use this single header file
to have a mocked FetchContext.

BUG=655920
==========

[commit-bot: I haz the power, 2016-11-14 10:28:34]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-14 10:31:44]

Description was changed from

==========
Loading: Factor out ResourceFetcherMockFetchContext

Factor out ResourceFetcherMockFetchContext as MockFetchContext
so that multiple unit tests can use it for mocking FetchContext
on unit tests.

I'm planning to split ResourceFetcherTest.cpp into multiple files
so that I can remove undesirable dependencies from the tests to
Resource and ResourceClient sub-classes. Once the tests are split
into multiple files, they all will use this single header file
to have a mocked FetchContext.

BUG=655920
==========

to

==========
Loading: Factor out ResourceFetcherMockFetchContext

Factor out ResourceFetcherMockFetchContext as MockFetchContext
so that multiple unit tests can use it for mocking FetchContext
on unit tests.

I'm planning to split ResourceFetcherTest.cpp into multiple files
so that I can remove undesirable dependencies from the tests to
Resource and ResourceClient sub-classes. Once the tests are split
into multiple files, they all will use this single header file
to have a mocked FetchContext.

BUG=655920

Committed: https://crrev.com/162f29c10a4d1e9d037ed42c34eb9460ae20a5bb
Cr-Commit-Position: refs/heads/master@{#431849}
==========

[commit-bot: I haz the power, 2016-11-14 10:31:45]

Patchset 4 (id:??) landed as
https://crrev.com/162f29c10a4d1e9d037ed42c34eb9460ae20a5bb
Cr-Commit-Position: refs/heads/master@{#431849}