Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/TestPermissiveDictionary.h

Issue 2494973002: bindings: Stop using Nullable<T> in dictionary impl (Closed)
Patch Set: Comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/TestPermissiveDictionary.h
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/TestPermissiveDictionary.h b/third_party/WebKit/Source/bindings/tests/results/core/TestPermissiveDictionary.h
index cc9d80ffd3f8e565ce063308d7fa4008a3654584..75f484d27a030c3a8874dbd544eec4aa3f3d94de 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/TestPermissiveDictionary.h
+++ b/third_party/WebKit/Source/bindings/tests/results/core/TestPermissiveDictionary.h
@@ -10,7 +10,6 @@
#define TestPermissiveDictionary_h
#include "bindings/core/v8/IDLDictionaryBase.h"
-#include "bindings/core/v8/Nullable.h"
#include "core/CoreExport.h"
#include "platform/heap/Handle.h"
@@ -22,15 +21,16 @@ class CORE_EXPORT TestPermissiveDictionary : public IDLDictionaryBase {
TestPermissiveDictionary();
virtual ~TestPermissiveDictionary();
- bool hasBooleanMember() const { return !m_booleanMember.isNull(); }
- bool booleanMember() const { return m_booleanMember.get(); }
- void setBooleanMember(bool value) { m_booleanMember = value; }
+ bool hasBooleanMember() const;
+ bool booleanMember() const;
+ void setBooleanMember(bool);
v8::Local<v8::Value> toV8Impl(v8::Local<v8::Object>, v8::Isolate*) const override;
DECLARE_VIRTUAL_TRACE();
private:
- Nullable<bool> m_booleanMember;
+ bool m_hasBooleanMember = false;
+ bool m_booleanMember;
friend class V8TestPermissiveDictionary;
};

Powered by Google App Engine
This is Rietveld 408576698