third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl - Issue 2494973002: bindings: Stop using Nullable<T> in dictionary impl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl

Issue 2494973002: bindings: Stop using Nullable<T> in dictionary impl (Closed)

Patch Set: Comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/dictionary_impl.cpp.tmpl ('k') | third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl b/third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl

index c7c15cf7b3d1674f549d309987ad17d98d22bced..f69a7bddf3bb496110998c938927a415c192790f 100644

--- a/third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl

@@ -18,11 +18,11 @@ class {{exported}}{{cpp_class}}{% if parent_cpp_class %} : public {{parent_cpp_c

virtual ~{{cpp_class}}();

{% for member in members %}

- bool {{member.has_method_name}}() const { return {{member.has_method_expression}}; }

- {{member.rvalue_cpp_type}} {{member.cpp_name}}() const { return {{member.getter_expression}}; }

- void {{member.setter_name}}({{member.rvalue_cpp_type}} value) { m_{{member.cpp_name}} = value; }

+ bool {{member.has_method_name}}() const;

+ {{member.rvalue_cpp_type}} {{member.cpp_name}}() const;

+ void {{member.setter_name}}({{member.rvalue_cpp_type}});

{% if member.null_setter_name %}

- void {{member.null_setter_name}}() { m_{{member.cpp_name}} = {{member.member_cpp_type}}(); }

+ void {{member.null_setter_name}}();

{% endif %}

{% endfor %}

@@ -31,6 +31,9 @@ class {{exported}}{{cpp_class}}{% if parent_cpp_class %} : public {{parent_cpp_c

private:

{% for member in members %}

+ {% if member.nullable_indicator_name %}

+ bool {{member.nullable_indicator_name}} = false;

+ {% endif %}

{{member.member_cpp_type}} m_{{member.cpp_name}};

{% endfor %}