Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_types.py

Issue 2494973002: bindings: Stop using Nullable<T> in dictionary impl (Closed)
Patch Set: Comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/v8_types.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_types.py b/third_party/WebKit/Source/bindings/scripts/v8_types.py
index 6fcbe63720776dc8f650397d49b3e84f82d65448..242020bfe48c054bc65a198b6d1548f45e00e00f 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_types.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_types.py
@@ -422,17 +422,8 @@ def add_includes_for_interface(interface_name):
includes.update(includes_for_interface(interface_name))
-def impl_should_use_nullable_container(idl_type):
- return not(idl_type.cpp_type_has_null_value)
-
-IdlTypeBase.impl_should_use_nullable_container = property(
- impl_should_use_nullable_container)
-
-
def impl_includes_for_type(idl_type, interfaces_info):
includes_for_type = set()
- if idl_type.impl_should_use_nullable_container:
- includes_for_type.add('bindings/core/v8/Nullable.h')
idl_type = idl_type.preprocessed_type
native_array_element_type = idl_type.native_array_element_type

Powered by Google App Engine
This is Rietveld 408576698