Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Side by Side Diff: third_party/WebKit/Source/bindings/templates/dictionary_impl.cpp.tmpl

Issue 2494973002: bindings: Stop using Nullable<T> in dictionary impl (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% filter format_blink_cpp_source_code %} 1 {% filter format_blink_cpp_source_code %}
2 2
3 {% include 'copyright_block.txt' %} 3 {% include 'copyright_block.txt' %}
4 #include "{{cpp_class}}.h" 4 #include "{{cpp_class}}.h"
5 5
6 {% for filename in cpp_includes %} 6 {% for filename in cpp_includes %}
7 #include "{{filename}}" 7 #include "{{filename}}"
8 {% endfor %} 8 {% endfor %}
9 9
10 namespace blink { 10 namespace blink {
11 11
12 {# Constructor #} 12 {# Constructor #}
13 {{cpp_class}}::{{cpp_class}}() { 13 {{cpp_class}}::{{cpp_class}}() {
14 {% for member in members if member.cpp_default_value %} 14 {% for member in members if member.cpp_default_value %}
15 {{member.setter_name}}({{member.cpp_default_value}}); 15 {{member.setter_name}}({{member.cpp_default_value}});
16 {% endfor %} 16 {% endfor %}
17 } 17 }
18 18
19 {{cpp_class}}::~{{cpp_class}}() {} 19 {{cpp_class}}::~{{cpp_class}}() {}
20 20
21 {% for member in members %}
22 bool {{cpp_class}}::{{member.has_method_name}}() const {
23 return {{member.has_method_expression}};
24 }
25 {{member.rvalue_cpp_type}} {{cpp_class}}::{{member.cpp_name}}() const {
26 return {{member.getter_expression}};
27 }
28 void {{cpp_class}}::{{member.setter_name}}({{member.rvalue_cpp_type}} value) {
29 m_{{member.cpp_name}} = value;
30 {% if member.has_flag_variable %}
31 {{member.has_flag_variable}} = true;
32 {% endif %}
33 }
34 {% if member.null_setter_name %}
35 void {{cpp_class}}::{{member.null_setter_name}}() {
36 {% if member.has_flag_variable %}
37 {{member.has_flag_variable}} = false;
38 {% else %}
peria 2016/11/11 07:45:16 {%endif%} here. otherwise, it keeps unused m_{{me
bashi 2016/11/11 07:52:57 IIUC the purpose of this method is make hasXXX() r
39 m_{{member.cpp_name}} = {{member.member_cpp_type}}();
40 {% endif %}
41 }
42 {% endif %}
43 {% endfor %}
44
21 DEFINE_TRACE({{cpp_class}}) { 45 DEFINE_TRACE({{cpp_class}}) {
22 {% for member in members if member.is_traceable %} 46 {% for member in members if member.is_traceable %}
23 visitor->trace(m_{{member.cpp_name}}); 47 visitor->trace(m_{{member.cpp_name}});
24 {% endfor %} 48 {% endfor %}
25 {% if parent_cpp_class %} 49 {% if parent_cpp_class %}
26 {{parent_cpp_class}}::trace(visitor); 50 {{parent_cpp_class}}::trace(visitor);
27 {% endif %} 51 {% endif %}
28 } 52 }
29 53
30 } // namespace blink 54 } // namespace blink
31 55
32 {% endfilter %}{# format_blink_cpp_source_code #} 56 {% endfilter %}{# format_blink_cpp_source_code #}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698