Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2494963003: Serialize the text-decoration shorthand (Closed)

Created:
4 years, 1 month ago by drott
Modified:
4 years, 1 month ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Serialize the text-decoration shorthand The shorthand text-decoration should be accessible and correctly serialized on the computed style of an element. Without this implementation, the CSS code would default serialize those values only into the longhand forms. TEST=fast/css3-text/css3-text-decoration/text-decoration-shorthand.html BUG=613451 Committed: https://crrev.com/05bbe1b2538e2f9722f0e9881e70e24b7e264c63 Cr-Commit-Position: refs/heads/master@{#431853}

Patch Set 1 #

Patch Set 2 : Added rebaselines #

Patch Set 3 : Removed spurious newline #

Messages

Total messages: 18 (11 generated)
drott
Added rebaselines
4 years, 1 month ago (2016-11-11 13:09:07 UTC) #3
drott
4 years, 1 month ago (2016-11-11 13:58:41 UTC) #7
drott
Removed spurious newline
4 years, 1 month ago (2016-11-11 13:59:50 UTC) #8
Timothy Loh
lgtm
4 years, 1 month ago (2016-11-14 03:22:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494963003/40001
4 years, 1 month ago (2016-11-14 08:56:16 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-14 10:43:19 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 10:45:49 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/05bbe1b2538e2f9722f0e9881e70e24b7e264c63
Cr-Commit-Position: refs/heads/master@{#431853}

Powered by Google App Engine
This is Rietveld 408576698