[ash-md] Added a delay between system menu default/detailed view transitions.

base/test/scoped_mock_time_message_loop_task_runner.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BASE_TEST_SCOPED_MOCK_TIME_MESSAGE_LOOP_TASK_RUNNER_H_
+#define BASE_TEST_SCOPED_MOCK_TIME_MESSAGE_LOOP_TASK_RUNNER_H_
+
+#include <stddef.h>

[gab, 2016/11/18 15:13:54]

rm

[bruthig, 2016/11/18 16:44:52]

Done.

+
+#include <memory>

[gab, 2016/11/18 15:13:54]

For scoped_refptr you don't need this one, you need "base/memory/ref_counted.h"

[bruthig, 2016/11/18 16:44:52]

Done.

+#include <queue>

[gab, 2016/11/18 15:13:54]

rm

[bruthig, 2016/11/18 16:44:52]

Done.

+#include <vector>

[gab, 2016/11/18 15:13:54]

rm

[bruthig, 2016/11/18 16:44:52]

Done.

+
+#include "base/macros.h"
+#include "base/single_thread_task_runner.h"

[gab, 2016/11/18 15:13:54]

nit: include only required in .cc (fwd-decl below is sufficient as type is only
used in .cc)

[bruthig, 2016/11/18 16:44:53]

Done.

+#include "base/synchronization/lock.h"

[gab, 2016/11/18 15:13:54]

rm

[bruthig, 2016/11/18 16:44:53]

Done.

+#include "base/test/test_pending_task.h"

[gab, 2016/11/18 15:13:54]

rm

[bruthig, 2016/11/18 16:44:52]

Done.

+#include "base/threading/thread_checker.h"

[gab, 2016/11/18 15:13:54]

rm

[bruthig, 2016/11/18 16:44:52]

Done.

+#include "base/time/time.h"

[gab, 2016/11/18 15:13:54]

to .cc

[bruthig, 2016/11/18 16:44:53]

Done.

+
+namespace base {
+
+class TestMockTimeTaskRunner;

[gab, 2016/11/18 15:13:54]

Since I can't imagine anyone using this class without also requiring
TestMockTimeTaskRunner, how about we

#include "base/test/test_mock_time_task_runner.h"

in this file instead of .cc and alleviate the need for users to always include
both headers.

[gab, 2016/11/18 15:13:54]

Along similar lines of thoughts as the above how about we replace task_runner()
with:

TestMockTimeTaskRunner* operator->() { return task_runner_.get(); }

(to allow scoped_task_runner_->FastForwardBy(...);)

Then users don't need two members (your use case is simple but I'm just starting
to use it for another unit test issue I'm trying to solve and I need the
TestMockTimeTaskRunner* as a member to avoid verbose calls which is kind of
redundant...).

(can also keep the task_runner() method, e.g. for tests and for users that might
care about handing off the TaskRunner to a sub-component)

[bruthig, 2016/11/18 16:44:52]

Done.

[bruthig, 2016/11/18 16:44:52]

Done.

+class SingleThreadTaskRunner;
+
+// A scoped wrapper around TestMockTimeTaskRunner that replaces
+// MessageLoop::current()'s task runner (and consequently
+// ThreadTaskRunnerHandle) with a TestMockTimeTaskRunner and resets it back at
+// the end of the scope.

[gab, 2016/11/18 15:13:54]

Another thing I noticed when using this for my own use case is that it breaks
RunLoop() (which still pumps messages from the MessageLoop's original queue).

This should at least be noted in a comment here:

// Note: RunLoop() will not work in the scope of a
ScopedMockTimeMessageLoopTaskRunner, the underlying TestMockTimeTaskRunner's
methods must be used instead to pump tasks.

[bruthig, 2016/11/18 16:44:52]

Done.

+class ScopedMockTimeMessageLoopTaskRunner {
+ public:
+  ScopedMockTimeMessageLoopTaskRunner();
+  ~ScopedMockTimeMessageLoopTaskRunner();
+
+  TestMockTimeTaskRunner* task_runner() { return task_runner_.get(); }
+
+ private:
+  const scoped_refptr<TestMockTimeTaskRunner> task_runner_;
+  scoped_refptr<SingleThreadTaskRunner> previous_task_runner_;
+
+  DISALLOW_COPY_AND_ASSIGN(ScopedMockTimeMessageLoopTaskRunner);
+};
+
+}  // namespace base
+
+#endif  // BASE_TEST_SCOPED_MOCK_TIME_MESSAGE_LOOP_TASK_RUNNER_H_