[ash-md] Added a delay between system menu default/detailed view transitions.

base/test/test_mock_time_task_runner.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/test/test_mock_time_task_runner.h"
 
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted.h"
+#include "base/message_loop/message_loop.h"
+#include "base/threading/thread_task_runner_handle.h"
 #include "base/time/clock.h"
 #include "base/time/tick_clock.h"
 
 namespace base {
 
 namespace {
 
 // MockTickClock --------------------------------------------------------------
 
 // TickClock that always returns the then-current mock time ticks of
@@ skipping 238 matching lines @@
   AutoLock scoped_lock(tasks_lock_);
   if (!tasks_.empty() &&
       (tasks_.top().GetTimeToRun() - reference) <= max_delta) {
     *next_task = tasks_.top();
     tasks_.pop();
     return true;
   }
   return false;
 }
 
+// ScopedTestMockTimeTaskRunner -----------------------------------------------
+
+ScopedMockTaskRunnerWrapper::ScopedMockTaskRunnerWrapper() {

[gab, 2016/11/15 19:52:01]

DCHECK(base::MessageLoop::current());

[gab, 2016/11/15 19:52:01]

: task_runner_(new base::TestMockTimeTaskRunner),
  previous_task_runner_(base::ThreadTaskRunnerHandle::Get()) {

[bruthig, 2016/11/15 21:52:44]

Done.

[bruthig, 2016/11/15 21:52:44]

Done.

+  task_runner_ = new base::TestMockTimeTaskRunner;
+  previous_task_runner_ = base::ThreadTaskRunnerHandle::Get();
+  base::MessageLoop::current()->SetTaskRunner(task_runner_);
+}
+
+ScopedMockTaskRunnerWrapper::~ScopedMockTaskRunnerWrapper() {

[gab, 2016/11/15 19:52:01]

DCHECK(previous_task_runner_->RunsTasksOnCurrentThread());

(to confirm destructor is called on thread it originally overwrote)

[bruthig, 2016/11/15 21:52:44]

Done.

+  DCHECK_EQ(task_runner_, base::ThreadTaskRunnerHandle::Get());
+  task_runner_->ClearPendingTasks();

[gab, 2016/11/15 19:52:01]

This feels wrong. Remaining tasks should be transferred to
|previous_task_runner_| for continuation.

[bruthig, 2016/11/15 21:52:44]

Not exactly sure if I implemented what you were asking for here. Can you double
check?  Also let me know if there is a more efficient way of implementing
TestMockTimeTaskRunner::TakePendingTasks() with std:swap() or something.

+  base::MessageLoop::current()->SetTaskRunner(previous_task_runner_);

[gab, 2016/11/15 19:52:01]

->SetTaskRunner(std::move(previous_task_runner_));

(and #include <utility> for std::move)

[bruthig, 2016/11/15 21:52:44]

Done.

+}
+
 }  // namespace base