Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issue 2494943003: [MD settings] show full origin in content settings exceptions (Closed)

Created:
4 years, 1 month ago by dschuyler
Modified:
4 years, 1 month ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] show full origin in content settings exceptions This CL removes the filtering from the content settings excptions to show the full exception rule. BUG=662919 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c03ac1f988225abce504a023f29db90c6dbb2872 Cr-Commit-Position: refs/heads/master@{#431736}

Patch Set 1 #

Patch Set 2 : unit test fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -12 lines) Patch
M chrome/browser/resources/settings/site_settings/site_settings_behavior.js View 1 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/test/data/webui/settings/site_list_tests.js View 1 2 chunks +20 lines, -9 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
dschuyler
4 years, 1 month ago (2016-11-11 21:45:22 UTC) #4
Dan Beam
lgtm
4 years, 1 month ago (2016-11-11 22:09:10 UTC) #6
dschuyler
There were unit tests checking that sites would be combined. Since this CL is no ...
4 years, 1 month ago (2016-11-11 23:49:30 UTC) #11
Dan Beam
still lgtm
4 years, 1 month ago (2016-11-11 23:53:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494943003/20001
4 years, 1 month ago (2016-11-12 01:42:46 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-12 01:55:17 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-12 01:58:04 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c03ac1f988225abce504a023f29db90c6dbb2872
Cr-Commit-Position: refs/heads/master@{#431736}

Powered by Google App Engine
This is Rietveld 408576698